From: Ilya Tocar <tocarip.intel@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH, i386][3/3] Update to match latest AVX512 spec.
Date: Tue, 25 Feb 2014 16:25:00 -0000 [thread overview]
Message-ID: <20140225162451.GB75072@msticlxl7.ims.intel.com> (raw)
In-Reply-To: <CAMe9rOrJb0qCEmznJ08vmc+BjCJwfQQ6i=Oq_rSZTfoo30fG2A@mail.gmail.com>
> >>> vcvtps2ph supports memory destination. Please add AVX512F testcases
> >>> with memory destination.
> >>>
> >> We already have such tests. See e. g. on lines 6883-6890 in
> >> gas/testsuite/gas/i386/avx512f.s we have:
> >>
> >> vcvtps2ph $0xab, %zmm6, (%ecx) # AVX512F
> >> vcvtps2ph $0xab, %zmm6, (%ecx){%k7} # AVX512F
> >> vcvtps2ph $123, %zmm6, (%ecx) # AVX512F
> >> vcvtps2ph $123, %zmm6, -123456(%esp,%esi,8) # AVX512F
> >> vcvtps2ph $123, %zmm6, 4064(%edx) # AVX512F Disp8
> >> vcvtps2ph $123, %zmm6, 4096(%edx) # AVX512F
> >> vcvtps2ph $123, %zmm6, -4096(%edx) # AVX512F Disp8
> >>
> >> Do we need additional tests?
> >
> > Yes, please test with memory destination for:
> >
> > vcvtps2ph, 3, 0x661D, None, 1, CpuAVX512F,
> > Modrm|EVex=1|Masking=2|VexOpcode=2|VexW=1|IgnoreSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|SAE,
> > { Imm8, Imm8, RegZMM|RegMem }
This variant is removed in my patch. What exactly should I test?
>
> Also for
>
> vcvtps2ph, 4, 0x661D, None, 1, CpuAVX512F,
> Modrm|EVex=1|Masking=3|VexOpcode=2|VexW=1|IgnoreSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|SAE,
> { Imm8, Imm8, RegZMM, RegYMM|RegMem }
This is reg-reg version with SAE, which is already tested on e. g.
line 2602 in gas/testsuite/gas/i386/avx512f.s:
vcvtps2ph $0xab, {sae}, %zmm5, %ymm6{%k7} # AVX512F
Also instruction can't have memory operand and SAE at the same time.
next prev parent reply other threads:[~2014-02-25 16:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 15:20 [PATCH, i386][1/3] " Ilya Tocar
2014-02-20 15:59 ` H.J. Lu
2014-02-21 13:31 ` [PATCH, i386][2/3] " Ilya Tocar
2014-02-21 16:07 ` H.J. Lu
2014-03-20 17:29 ` H.J. Lu
2014-02-24 13:22 ` [PATCH, i386][3/3] " Ilya Tocar
2014-02-24 16:30 ` H.J. Lu
2014-02-25 9:41 ` Ilya Tocar
2014-02-25 15:54 ` H.J. Lu
2014-02-25 16:03 ` H.J. Lu
2014-02-25 16:25 ` Ilya Tocar [this message]
2014-02-25 16:53 ` H.J. Lu
2014-03-20 17:30 ` H.J. Lu
2014-03-20 17:27 ` [PATCH, i386][1/3] " H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225162451.GB75072@msticlxl7.ims.intel.com \
--to=tocarip.intel@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).