From: Alan Modra <amodra@gmail.com>
To: Ed Maste <emaste@freebsd.org>
Cc: binutils@sourceware.org
Subject: Re: gas emits incorrect .debug_line prologue header length for 64-bit DWARF
Date: Fri, 28 Feb 2014 04:38:00 -0000 [thread overview]
Message-ID: <20140228043830.GH14922@bubble.grove.modra.org> (raw)
In-Reply-To: <CAPyFy2D4WizPNHZcA7syz_ETEasLcC3kCC0hQ74qP=ZnGiBoVw@mail.gmail.com>
On Thu, Feb 27, 2014 at 01:03:23PM -0500, Ed Maste wrote:
> The header_length field is supposed to be the number of bytes
> following the field to the first byte of the line number program, but
> dwarf2dbg.c:out_debug_line has hard-coded constants that are correct
> only for 32-bit DWARF.
>
> I've fixed it in FreeBSD here in SVN r256692:
> http://svnweb.freebsd.org/base?view=revision&revision=256692
Thanks for the heads-up. I'm committing the following to mainline
that calculates the length as a simple difference of two symbols.
* dwarf2dbg.c (out_debug_line): Correct .debug_line header_length
field for 64-bit dwarf.
diff --git a/gas/dwarf2dbg.c b/gas/dwarf2dbg.c
index 6d6ee2d..ac6148f 100644
--- a/gas/dwarf2dbg.c
+++ b/gas/dwarf2dbg.c
@@ -1515,7 +1515,7 @@ static void
out_debug_line (segT line_seg)
{
expressionS exp;
- symbolS *prologue_end;
+ symbolS *prologue_start, *prologue_end;
symbolS *line_end;
struct line_seg *s;
int sizeof_offset;
@@ -1527,10 +1527,14 @@ out_debug_line (segT line_seg)
out_two (DWARF2_LINE_VERSION);
/* Length of the prologue following this length. */
+ prologue_start = symbol_temp_make ();
prologue_end = symbol_temp_make ();
+ exp.X_op = O_subtract;
exp.X_add_symbol = prologue_end;
- exp.X_add_number = - (4 + 2 + 4);
+ exp.X_op_symbol = prologue_start;
+ exp.X_add_number = 0;
emit_expr (&exp, sizeof_offset);
+ symbol_set_value_now (prologue_start);
/* Parameters of the state machine. */
out_byte (DWARF2_LINE_MIN_INSN_LENGTH);
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2014-02-28 4:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 18:03 Ed Maste
2014-02-28 4:38 ` Alan Modra [this message]
2014-02-28 17:52 ` Ed Maste
2014-03-01 22:17 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228043830.GH14922@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=emaste@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).