From: Alan Modra <amodra@gmail.com>
To: Jon TURNEY <jon.turney@dronecode.org.uk>
Cc: Nicholas Clifton <nickc@redhat.com>, binutils@sourceware.org
Subject: Re: [PATCH 1/2] pe/coff: Avoid a crash using objdump -p on the output of objcopy --only-keep-debug
Date: Wed, 09 Apr 2014 04:37:00 -0000 [thread overview]
Message-ID: <20140409043740.GG13391@bubble.grove.modra.org> (raw)
In-Reply-To: <5344428D.1010000@dronecode.org.uk>
Fix fallout from splitting ldbuildid.[ch] off elf32.em.
Applied.
bfd/
* libcoff.h: Regenerate.
ld/
* emultempl/spuelf.em: Include safe-ctype.h, remove duplicate errno.h.
* emultempl/nds32elf.em: Include bfd_stdint.h.
* po/POTFILES.in: Regenerate.
diff --git a/bfd/libcoff.h b/bfd/libcoff.h
index 6cb387c..19ba7e7 100644
--- a/bfd/libcoff.h
+++ b/bfd/libcoff.h
@@ -124,7 +124,7 @@ typedef struct pe_tdata
bfd_boolean (*in_reloc_p) (bfd *, reloc_howto_type *);
flagword real_flags;
- /* build-id info. */
+ /* Build-id info. */
struct
{
bfd_boolean (*after_write_object_contents) (bfd *);
diff --git a/ld/emultempl/nds32elf.em b/ld/emultempl/nds32elf.em
index 417eda5..96e6aa3 100644
--- a/ld/emultempl/nds32elf.em
+++ b/ld/emultempl/nds32elf.em
@@ -25,6 +25,7 @@ fragment <<EOF
#include "libbfd.h"
#include "elf-bfd.h"
#include "elf/nds32.h"
+#include "bfd_stdint.h"
#include "elf32-nds32.h"
static int relax_fp_as_gp = 1; /* --mrelax-omit-fp */
diff --git a/ld/emultempl/spuelf.em b/ld/emultempl/spuelf.em
index eaf4de7..5167b35 100644
--- a/ld/emultempl/spuelf.em
+++ b/ld/emultempl/spuelf.em
@@ -447,7 +447,7 @@ EOF
if grep -q 'ld_elf.*ppc.*_emulation' ldemul-list.h; then
fragment <<EOF
-#include <errno.h>
+#include "safe-ctype.h"
#include "filenames.h"
#include "libiberty.h"
diff --git a/ld/po/POTFILES.in b/ld/po/POTFILES.in
index 55cbd13..fcc2894 100644
--- a/ld/po/POTFILES.in
+++ b/ld/po/POTFILES.in
@@ -3,6 +3,8 @@ elf-hints-local.h
emultempl/armcoff.em
emultempl/pe.em
ld.h
+ldbuildid.c
+ldbuildid.h
ldcref.c
ldctor.c
ldctor.h
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2014-04-09 4:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 14:39 [PATCH 0/2] pe/coff: Improve 'objdump -p' handling of the output of 'objcopy --only-keep-debug' Jon TURNEY
2014-03-18 14:39 ` [PATCH 1/2] pe/coff: Avoid a crash using objdump -p on the output of objcopy --only-keep-debug Jon TURNEY
2014-04-03 4:02 ` Christopher Faylor
2014-04-03 11:28 ` Nicholas Clifton
2014-04-04 14:47 ` Jon TURNEY
2014-04-08 10:04 ` Nicholas Clifton
2014-04-08 18:40 ` Jon TURNEY
2014-04-09 4:37 ` Alan Modra [this message]
2014-03-18 14:39 ` [PATCH 2/2] pe/coff: Don't try to interpret the contents of sections with no contents for 'objdump -p' Jon TURNEY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409043740.GG13391@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jon.turney@dronecode.org.uk \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).