From: Alan Modra <amodra@gmail.com>
To: Mike Stump <mikestump@comcast.net>
Cc: Andrew Pinski <pinskia@gmail.com>, binutils <binutils@sourceware.org>
Subject: Re: as error output not -j64 safe
Date: Fri, 16 May 2014 08:51:00 -0000 [thread overview]
Message-ID: <20140516085119.GW5162@bubble.grove.modra.org> (raw)
In-Reply-To: <36FD025D-0FE1-4248-A154-E28F998F5B73@comcast.net>
On Thu, May 15, 2014 at 04:13:24PM -0700, Mike Stump wrote:
> --- a/binutils/gas/messages.c
> +++ b/binutils/gas/messages.c
> @@ -219,13 +219,12 @@ as_bad_internal (char *file, unsigned int line, char *buffer)
> if (file)
> {
> if (line != 0)
> - fprintf (stderr, "%s:%u: ", file, line);
> + fprintf (stderr, "%s:%u: %s %s\n", file, line, _("Error:"), buffer);
> else
> - fprintf (stderr, "%s: ", file);
> + fprintf (stderr, "%s: %s %s\n", file, _("Error:"), buffer);
> }
> - fprintf (stderr, _("Error: "));
> - fputs (buffer, stderr);
> - (void) putc ('\n', stderr);
> + else
> + fprintf (stderr, "%s %s\n", _("Error:"), buffer);
> #ifndef NO_LISTING
> listing_error (buffer);
> #endif
OK. Please also fix as_warn_internal similarly to the above. There
are quite a few more cases of the same problem in this file, if you
care to look..
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2014-05-16 8:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 22:48 Mike Stump
2014-05-15 22:52 ` Andrew Pinski
2014-05-15 23:13 ` Mike Stump
2014-05-16 8:51 ` Alan Modra [this message]
2014-05-20 20:28 ` Mike Stump
2014-05-20 22:01 ` Matthew Fortune
2014-05-20 22:49 ` Matthew Fortune
2014-05-20 22:57 ` Mike Stump
2014-05-22 7:22 ` Alan Modra
2014-05-22 8:10 ` Mike Stump
2014-05-22 8:40 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516085119.GW5162@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=mikestump@comcast.net \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).