From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-83738-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 26475 invoked by alias); 16 May 2014 08:51:28 -0000
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
Received: (qmail 26463 invoked by uid 89); 16 May 2014 08:51:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-pa0-f49.google.com
Received: from mail-pa0-f49.google.com (HELO mail-pa0-f49.google.com) (209.85.220.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 16 May 2014 08:51:26 +0000
Received: by mail-pa0-f49.google.com with SMTP id lj1so2266320pab.8        for <binutils@sourceware.org>; Fri, 16 May 2014 01:51:25 -0700 (PDT)
X-Received: by 10.68.202.8 with SMTP id ke8mr19123861pbc.86.1400230285000;        Fri, 16 May 2014 01:51:25 -0700 (PDT)
Received: from bubble.grove.modra.org ([101.166.26.37])        by mx.google.com with ESMTPSA id nh8sm13332146pbc.25.2014.05.16.01.51.23        for <multiple recipients>        (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);        Fri, 16 May 2014 01:51:24 -0700 (PDT)
Received: by bubble.grove.modra.org (Postfix, from userid 1000)	id 19FCFEA0178; Fri, 16 May 2014 18:21:20 +0930 (CST)
Date: Fri, 16 May 2014 08:51:00 -0000
From: Alan Modra <amodra@gmail.com>
To: Mike Stump <mikestump@comcast.net>
Cc: Andrew Pinski <pinskia@gmail.com>, binutils <binutils@sourceware.org>
Subject: Re: as error output not -j64 safe
Message-ID: <20140516085119.GW5162@bubble.grove.modra.org>
Mail-Followup-To: Mike Stump <mikestump@comcast.net>,	Andrew Pinski <pinskia@gmail.com>,	binutils <binutils@sourceware.org>
References: <819223B1-7BDF-46C0-80CE-EF49878BA3C8@comcast.net> <CA+=Sn1m3VExcetsFHU62+aKDbQYyZTJjYjX1UE0KfovhwyhyXw@mail.gmail.com> <36FD025D-0FE1-4248-A154-E28F998F5B73@comcast.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <36FD025D-0FE1-4248-A154-E28F998F5B73@comcast.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
X-SW-Source: 2014-05/txt/msg00139.txt.bz2

On Thu, May 15, 2014 at 04:13:24PM -0700, Mike Stump wrote:
> --- a/binutils/gas/messages.c
> +++ b/binutils/gas/messages.c
> @@ -219,13 +219,12 @@ as_bad_internal (char *file, unsigned int line, char *buffer)
>    if (file)
>      {
>        if (line != 0)
> -       fprintf (stderr, "%s:%u: ", file, line);
> +       fprintf (stderr, "%s:%u: %s %s\n", file, line, _("Error:"), buffer);
>        else
> -       fprintf (stderr, "%s: ", file);
> +       fprintf (stderr, "%s: %s %s\n", file, _("Error:"), buffer);
>      }
> -  fprintf (stderr, _("Error: "));
> -  fputs (buffer, stderr);
> -  (void) putc ('\n', stderr);
> +  else
> +    fprintf (stderr, "%s %s\n", _("Error:"), buffer);
>  #ifndef NO_LISTING
>    listing_error (buffer);
>  #endif

OK.  Please also fix as_warn_internal similarly to the above.  There
are quite a few more cases of the same problem in this file, if you
care to look..

-- 
Alan Modra
Australia Development Lab, IBM