From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16910 invoked by alias); 4 Jun 2014 12:55:43 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 16888 invoked by uid 89); 4 Jun 2014 12:55:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 04 Jun 2014 12:55:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 12F181160E0; Wed, 4 Jun 2014 08:55:40 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3AAERnmTOXVK; Wed, 4 Jun 2014 08:55:40 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B11EF1160A9; Wed, 4 Jun 2014 08:55:39 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9FD2740EB3; Wed, 4 Jun 2014 05:55:41 -0700 (PDT) Date: Wed, 04 Jun 2014 12:55:00 -0000 From: Joel Brobecker To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, binutils@sourceware.org, Alan Modra , Hans-Peter Nilsson , Tom Tromey Subject: Re: [RFA v2] Make it easy to make --disable-werror the default for both binutils and gdb Message-ID: <20140604125541.GT4289@adacore.com> References: <1401811030-22706-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-06/txt/msg00037.txt.bz2 > > . Use "-a" instead of "&&" in the test expression; (H-P) > > I think Hans-Peter's suggestion was the other way round, its "&&" that is > portable while "-a" is likely not to work with non-GNU `test' or with > plain Bourne shells (where it is a builtin). This is what the autoconf > manual has to say about it in its portability section: Hmmm, I see. Thanks for theh clarification. I propose the following: Keep the patch I propose as is for now, as it does not make things worse, and also keep things consistent. And then follow that up with a patch which switches the operators, all of them, to using &&. -- Joel