From: Alan Modra <amodra@gmail.com>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>
Cc: binutils@sourceware.org
Subject: Re: 32-bit PowerPC sdata linker problem
Date: Fri, 06 Jun 2014 10:54:00 -0000 [thread overview]
Message-ID: <20140606105420.GH5592@bubble.grove.modra.org> (raw)
In-Reply-To: <53918356.3040102@embedded-brains.de>
On Fri, Jun 06, 2014 at 11:01:10AM +0200, Sebastian Huber wrote:
> I performed a git bisect and found this:
>
> 93d1b056cb396d6468781fe0e40dd769891bed32 is the first bad commit
> commit 93d1b056cb396d6468781fe0e40dd769891bed32
> Author: Alan Modra <amodra@gmail.com>
> Date: Tue May 20 11:42:42 2014 +0930
>
> Rewrite ppc32 backend .sdata and .sdata2 handling
Hmm, I'm surprised that your git bisect found this patch. Was
_SDA_BASE_ set differently before this?
> 0x00000000000dfc00 _SDA_BASE_
> 0x00000000000d7f78 ppc_exc_lock_std
> 4b8: 28 05 00 00 cmplwi r5,0
> 4ba: R_PPC_SDAREL16 ppc_exc_lock_std
ppc_exc_lock_std@sdarel will be calculating 0xd7f78 - 0xdfc00
which is 0xf...fff8378, and that falls foul of
commit 86c9573369616e7437481b6e5533aef3a435cdcf
Author: Alan Modra <amodra@gmail.com>
Date: Sat Mar 8 13:05:06 2014 +1030
Better overflow checking for powerpc32 relocations
cmplwi has an *unsigned* 16-bit field, and we now check the overflow
properly.
I wonder how many more of these we'll hit, and whether the uproar will
be enough that I'll be forced to relax the checks?
--
Alan Modra
Australia Development Lab, IBM
next parent reply other threads:[~2014-06-06 10:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53918356.3040102@embedded-brains.de>
2014-06-06 10:54 ` Alan Modra [this message]
2014-06-06 11:23 ` Sebastian Huber
2014-06-06 11:31 ` Sebastian Huber
2014-06-06 12:15 ` Alan Modra
2014-06-06 12:49 ` Sebastian Huber
[not found] ` <20140606130559.GK5592@bubble.grove.modra.org>
[not found] ` <5391C0E8.7010409@embedded-brains.de>
[not found] ` <20140606134915.GL5592@bubble.grove.modra.org>
[not found] ` <5391CCFB.5060206@embedded-brains.de>
2014-06-07 12:34 ` Alan Modra
2014-06-10 6:28 ` Sebastian Huber
2014-06-06 12:17 ` Alan Modra
2014-06-07 12:47 ` Alan Modra
2014-06-16 11:21 ` Will Newton
2014-06-16 13:07 ` Alan Modra
2014-06-16 14:10 ` Will Newton
2014-06-16 14:11 ` Will Newton
2014-06-18 0:29 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606105420.GH5592@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=sebastian.huber@embedded-brains.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).