public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] bfd/targets: create elf64 selvecs only if 64-bit bfd support is enabled.
@ 2014-06-19 14:10 Philippe De Muyter
  2014-06-20 23:56 ` Alan Modra
  0 siblings, 1 reply; 2+ messages in thread
From: Philippe De Muyter @ 2014-06-19 14:10 UTC (permalink / raw)
  To: binutils; +Cc: Philippe De Muyter

when compiling on a 32-bit target by

	./configure --enable-targets=all
	make

one gets error messages :
../bfd/.libs/libbfd.a(targets.o):(.rodata+0xbd4):
					undefined reference to `elf64_be_vec'
../bfd/.libs/libbfd.a(targets.o):(.rodata+0xbd8):
					undefined reference to `elf64_le_vec'
...

Fix that.

Signed-Off-By: Philippe De Muyter <phdm@macqel.be>
---
 bfd/targets.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/bfd/targets.c b/bfd/targets.c
index 0860dc5..65f4648 100644
--- a/bfd/targets.c
+++ b/bfd/targets.c
@@ -1028,8 +1028,10 @@ static const bfd_target * const _bfd_target_vector[] =
 	   the file even if we don't recognize the machine type.  */
 	&elf32_be_vec,
 	&elf32_le_vec,
+#ifdef BFD64
 	&elf64_be_vec,
 	&elf64_le_vec,
+#endif
 
 	&epiphany_elf32_vec,
 
@@ -1045,8 +1047,10 @@ static const bfd_target * const _bfd_target_vector[] =
 	&hppa_elf32_vec,
 	&hppa_elf32_linux_vec,
 	&hppa_elf32_nbsd_vec,
+#ifdef BFD64
 	&hppa_elf64_vec,
 	&hppa_elf64_linux_vec,
+#endif
 	&hppa_som_vec,
 
 	&i370_elf32_vec,
@@ -1110,10 +1114,12 @@ static const bfd_target * const _bfd_target_vector[] =
 	&ip2k_elf32_vec,
 	&iq2000_elf32_vec,
 
+#ifdef BFD64
 	&k1om_elf64_vec,
 	&k1om_elf64_fbsd_vec,
 	&l1om_elf64_vec,
 	&l1om_elf64_fbsd_vec,
+#endif
 
 	&lm32_elf32_vec,
 
-- 
1.8.1.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] bfd/targets: create elf64 selvecs only if 64-bit bfd support is enabled.
  2014-06-19 14:10 [PATCH] bfd/targets: create elf64 selvecs only if 64-bit bfd support is enabled Philippe De Muyter
@ 2014-06-20 23:56 ` Alan Modra
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Modra @ 2014-06-20 23:56 UTC (permalink / raw)
  To: Philippe De Muyter; +Cc: binutils

On Thu, Jun 19, 2014 at 04:10:09PM +0200, Philippe De Muyter wrote:
> when compiling on a 32-bit target by
> 
> 	./configure --enable-targets=all
> 	make
> 
> one gets error messages :
> ../bfd/.libs/libbfd.a(targets.o):(.rodata+0xbd4):
> 					undefined reference to `elf64_be_vec'
> ../bfd/.libs/libbfd.a(targets.o):(.rodata+0xbd8):
> 					undefined reference to `elf64_le_vec'
> ...
> 
> Fix that.

Thanks, committed 886aba9 with this changelog.

2014-06-21  Philippe De Muyter  <phdm@macqel.be>

	* targets.c (_bfd_target_vector): Add missing #ifdef BFD64 for
	a number of targets.

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-20 23:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-19 14:10 [PATCH] bfd/targets: create elf64 selvecs only if 64-bit bfd support is enabled Philippe De Muyter
2014-06-20 23:56 ` Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).