From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: amodra@gmail.com
Cc: binutils@sourceware.org, hjl.tools@gmail.com
Subject: Re: [PATCH] PR ld/16746: Don't issue a warning for reference in LTO IR
Date: Mon, 11 Aug 2014 22:21:00 -0000 [thread overview]
Message-ID: <201408112221.s7BMLlCi018860@ignucius.se.axis.com> (raw)
In-Reply-To: <20140807005451.GU8921@bubble.grove.modra.org> (message from Alan Modra on Thu, 7 Aug 2014 02:54:51 +0200)
> From: Alan Modra <amodra@gmail.com>
> Date: Thu, 7 Aug 2014 02:54:51 +0200
> So now that I've merged the WARN and CWARN
> my concern with HJ's patch is covered. This is what I'm about to
> commit on HJ's behalf.
>
> bfd/
> PR ld/16746
> * linker.c (_bfd_generic_link_add_one_symbol): Don't issue a
> warning for references in LTO IR to warning symbols.
>
> ld/testsuite/
> PR ld/16746
> * ld-plugin/lto.exp: Add 4 tests for PR ld/16746.
> * ld-plugin/pr16746a.c: New file.
> * ld-plugin/pr16746b.c: Likewise.
> * ld-plugin/pr16746c.c: Likewise.
> * ld-plugin/pr16746d.c: Likewise.
This, commit db7129469b, regressed ld-cris/warn3 for cris-elf:
Running /home/hp/binutils/src/ld/testsuite/ld-cris/cris.exp ...
FAIL: ld-cris/warn3
(The test-case checks stabs warning support for cris a.out; the
expected warning is no longer emitted after that commit. If you
want to remove stabs-aout-warning support altogether I don't
really mind, but I assume you agree that should be an explicit
change only done after verifying that there is no other issue
affecting warnings support. Stabs warnings for ELF was broken
since long, see ld-cris/warn4.d)
brgds, H-P
next prev parent reply other threads:[~2014-08-11 22:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 0:42 Merge WARN and CWARN cases in _bfd_generic_link_add_one_symbol Alan Modra
2014-08-07 0:55 ` [PATCH] PR ld/16746: Don't issue a warning for reference in LTO IR Alan Modra
2014-08-11 22:21 ` Hans-Peter Nilsson [this message]
2014-08-12 1:12 ` Alan Modra
-- strict thread matches above, loose matches on Subject: below --
2014-03-25 20:40 H.J. Lu
2014-03-25 22:39 ` Alan Modra
2014-03-25 22:50 ` H.J. Lu
2014-03-25 23:53 ` Alan Modra
2014-03-26 0:41 ` H.J. Lu
2014-03-26 19:29 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201408112221.s7BMLlCi018860@ignucius.se.axis.com \
--to=hans-peter.nilsson@axis.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).