From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21517 invoked by alias); 15 Aug 2014 12:49:22 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 21496 invoked by uid 89); 15 Aug 2014 12:49:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,UNSUBSCRIBE_BODY autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 15 Aug 2014 12:49:20 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B30A911652E; Fri, 15 Aug 2014 08:49:18 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Aa3CtFJCe1VI; Fri, 15 Aug 2014 08:49:18 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8AA7A1163C4; Fri, 15 Aug 2014 08:49:18 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5A4D6410C9; Fri, 15 Aug 2014 05:49:17 -0700 (PDT) Date: Fri, 15 Aug 2014 12:49:00 -0000 From: Joel Brobecker To: Will Newton Cc: gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: [RFC] src-release.sh: Convert src-release to a shell script Message-ID: <20140815124917.GB6037@adacore.com> References: <1407419590-27223-1-git-send-email-will.newton@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1407419590-27223-1-git-send-email-will.newton@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-08/txt/msg00123.txt.bz2 > 2014-08-07 Will Newton > > * src-release.sh: New file. Generally speaking, I tend to agree that a makefile is slightly overkill for this task. The contents of the makefile is fairly straightforward though, and outside of variable VEC in the makefile, you script doesn't look any simpler than the makefile... What I appreciate, however, is the lack of make recursions (with the associated multiple "make" processes). Give it another week for people to comment on, and then let's get this in (I'll take care of talking to Tristan when he comes back). Also, let's delete the old src-release script. Some relatively trivial comments below: > diff --git a/src-release.sh b/src-release.sh > new file mode 100755 > index 0000000..3d41269 > --- /dev/null > +++ b/src-release.sh > @@ -0,0 +1,353 @@ > +#!/bin/bash Can you use /usr/bin/env? People trying to create tarballs for their own might not be doing it on a GNU/Linux machine, and so bash might be installed elsewhere. > +# Copyright (C) 1990-2014 Free Software Foundation > +# > +# This file is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 2 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, write to the Free Software > +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. The copyright year range looks correct to me, but the license should be GPLv3. -- Joel