[BUILDROBOT] m86k breakage

[BUILDROBOT] m86k breakage

[Jan-Benedict Glaw]

[-- Attachment #1: Type: text/plain, Size: 1658 bytes --]

Hi Alan,

I observed that with a new-enough compiler, recent m68k builds break
(see eg.
http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=329738):

 gcc -DHAVE_CONFIG_H -I. -I/home/vaxbuild/repos/binutils_gdb/gas  -I. -I/home/vaxbuild/repos/binutils_gdb/gas -I../bfd -I/home/vaxbuild/repos/binutils_gdb/gas/config -I/home/vaxbuild/repos/binutils_gdb/gas/../include -I/home/vaxbuild/repos/binutils_gdb/gas/.. -I/home/vaxbuild/repos/binutils_gdb/gas/../bfd -DLOCALEDIR="\"/home/vaxbuild/build/m68k-linux/_install_/share/locale\""  -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -g -O2 -MT read.o -MD -MP -MF .deps/read.Tpo -c -o read.o /home/vaxbuild/repos/binutils_gdb/gas/read.c
/home/vaxbuild/repos/binutils_gdb/gas/read.c: In function ‘parse_mri_cons’:
/home/vaxbuild/repos/binutils_gdb/gas/read.c:3869:20: error: right-hand operand of comma expression has no effect [-Werror=unused-value]
   (expression (EXP), TC_PARSE_CONS_RETURN_NONE)
                    ^
/home/vaxbuild/repos/binutils_gdb/gas/read.c:4608:5: note: in expansion of macro ‘TC_PARSE_CONS_EXPRESSION’
     TC_PARSE_CONS_EXPRESSION (exp, nbytes);
     ^
cc1: all warnings being treated as errors


I think this is caused by the "gas TC_PARSE_CONS_EXPRESSION
communication with TC_CONS_FIX_NEW" commit (April 8th). Don't have a
tested patch yet...  Maybe I'll look into it tomorrow.

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:                   ...und wenn Du denkst, es geht nicht mehr,
the second  :                          kommt irgendwo ein Lichtlein her.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [BUILDROBOT] m86k breakage

[Alan Modra]

On Sat, Aug 16, 2014 at 04:14:59PM +0200, Jan-Benedict Glaw wrote:
> I think this is caused by the "gas TC_PARSE_CONS_EXPRESSION
> communication with TC_CONS_FIX_NEW" commit (April 8th).

Guilty as charged.

    	* read.c (parse_mri_cons): Warning fix.

diff --git a/gas/read.c b/gas/read.c
index 183ef2c..2d5fdf1 100644
--- a/gas/read.c
+++ b/gas/read.c
@@ -4605,7 +4605,7 @@ parse_mri_cons (expressionS *exp, unsigned int nbytes)
       && (input_line_pointer[1] != '\''
 	  || (*input_line_pointer != 'A'
 	      && *input_line_pointer != 'E')))
-    TC_PARSE_CONS_EXPRESSION (exp, nbytes);
+    (void) TC_PARSE_CONS_EXPRESSION (exp, nbytes);
   else
     {
       unsigned int scan;

-- 
Alan Modra
Australia Development Lab, IBM