[PATCH, nds32] Exclude building gdb for nds32*-*-* target.

[PATCH, nds32] Exclude building gdb for nds32*-*-* target.

[Chung-Ju Wu]

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

Hi, gdb & binutils maintainers,

Currently the nds32 port for gdb is still under contribution process.
So the gdb has not been supported yet for --target=nds32*-*-*.
It would be good if we can disable gdb before nds32 port for gdb is ready.

The attachment is the patch of configure.ac and I use autoconf 2.64
to regenerate configure.  But I notice some inconsistent changes between
configure.ac and configure.  Looks like there was something wrong on
previous commit 1f995db6ad2c9325a8db45b73fea29c8ab9200e1 ... and I just
accidentally fix it in this patch when regenerating configure. :p

The plain text ChangeLog is as below, is this patch OK for commit?


2014-09-05  Chung-Ju Wu  <jasonwucj@gmail.com>

    * configure.ac (nds32*-*-*): Disable gdb.
    * configure: Regenerated.


Best regards,
jasonwucj

[-- Attachment #2: 0001-Disable-gdb-for-nds32-until-supported.patch --]
[-- Type: application/octet-stream, Size: 1656 bytes --]

From a96bc4c1638187e18a6e2f71e2c158dddcf5d68f Mon Sep 17 00:00:00 2001
From: Chung-Ju Wu <jasonwucj@andestech.com>
Date: Fri, 5 Sep 2014 14:56:57 +0800
Subject: [PATCH] Disable gdb for nds32*-*-* until supported.

---
 configure    | 11 +++++++----
 configure.ac |  3 +++
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index 26c9886..dfea3bd 100755
--- a/configure
+++ b/configure
@@ -3369,10 +3369,6 @@ case "${target}" in
     ;;
   *-*-rtems*)
     noconfigdirs="$noconfigdirs ${libgcj}"
-    # this is not caught below because this stanza matches earlier
-    case $target in
-      or1k*-*-*) noconfigdirs="$noconfigdirs gdb" ;;
-    esac
     ;;
   *-*-tpf*)
     noconfigdirs="$noconfigdirs ${libgcj}"
@@ -3607,6 +3603,10 @@ case "${target}" in
     ;;
   *-*-rtems*)
     noconfigdirs="$noconfigdirs target-libgloss"
+    # this is not caught below because this stanza matches earlier
+    case $target in
+      or1k*-*-*) noconfigdirs="$noconfigdirs gdb" ;;
+    esac
     ;;
     # The tpf target doesn't support gdb yet.
   *-*-tpf*)
@@ -3805,6 +3805,9 @@ case "${target}" in
   mips*-*-*)
     noconfigdirs="$noconfigdirs gprof"
     ;;
+  nds32*-*-*)
+    noconfigdirs="$noconfigdirs gdb"
+    ;;
   or1k*-*-*)
     noconfigdirs="$noconfigdirs gdb"
     ;;
diff --git a/configure.ac b/configure.ac
index 028cbda..dada090 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1133,6 +1133,9 @@ case "${target}" in
   mips*-*-*)
     noconfigdirs="$noconfigdirs gprof"
     ;;
+  nds32*-*-*)
+    noconfigdirs="$noconfigdirs gdb"
+    ;;
   or1k*-*-*)
     noconfigdirs="$noconfigdirs gdb"
     ;;
-- 
1.9.0

Re: [PATCH, nds32] Exclude building gdb for nds32*-*-* target.

[Joel Sherrill]

On 9/5/2014 2:13 AM, Chung-Ju Wu wrote:
> Hi, gdb & binutils maintainers,
>
> Currently the nds32 port for gdb is still under contribution process.
> So the gdb has not been supported yet for --target=nds32*-*-*.
> It would be good if we can disable gdb before nds32 port for gdb is ready.
>
> The attachment is the patch of configure.ac and I use autoconf 2.64
> to regenerate configure.  But I notice some inconsistent changes between
> configure.ac and configure.  Looks like there was something wrong on
> previous commit 1f995db6ad2c9325a8db45b73fea29c8ab9200e1 ... and I just
> accidentally fix it in this patch when regenerating configure. :p
>
> The plain text ChangeLog is as below, is this patch OK for commit?
>
>
> 2014-09-05  Chung-Ju Wu  <jasonwucj@gmail.com>
>
>     * configure.ac (nds32*-*-*): Disable gdb.
>     * configure: Regenerated.
It looks like the part for not building gdb for or1k*-*-rtems* gets moved
by this patch.  I know there was an issue with the initial submission of
that change.

Your patch appears to correct that also. I thought the properly regenerated
configure had been committed. But I guess not.

I am OK with the patch since or1k-rtems is in the same place but wanted
to note that the generated file had extra stuff in it for a good reason.
>
> Best regards,
> jasonwucj

-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985

Re: [PATCH, nds32] Exclude building gdb for nds32*-*-* target.

[Joel Brobecker]

> > 2014-09-05  Chung-Ju Wu  <jasonwucj@gmail.com>
> >
> >     * configure.ac (nds32*-*-*): Disable gdb.
> >     * configure: Regenerated.
> It looks like the part for not building gdb for or1k*-*-rtems* gets moved
> by this patch.  I know there was an issue with the initial submission of
> that change.
> 
> Your patch appears to correct that also. I thought the properly regenerated
> configure had been committed. But I guess not.
> 
> I am OK with the patch since or1k-rtems is in the same place but wanted
> to note that the generated file had extra stuff in it for a good reason.

We really should regenerate configure first, and then apply Chung-Ju's
patch next. There will come a day when we will be reverting that
patch, since hopefully GDB will be building for that target, one day.
We don't want the revert to accidently also revert the bits that
that resync configure with present-day configure.ac.

-- 
Joel

Re: [PATCH, nds32] Exclude building gdb for nds32*-*-* target.

[Joel Sherrill]

On 9/5/2014 12:00 PM, Joel Brobecker wrote:
>>> 2014-09-05  Chung-Ju Wu  <jasonwucj@gmail.com>
>>>
>>>     * configure.ac (nds32*-*-*): Disable gdb.
>>>     * configure: Regenerated.
>> It looks like the part for not building gdb for or1k*-*-rtems* gets moved
>> by this patch.  I know there was an issue with the initial submission of
>> that change.
>>
>> Your patch appears to correct that also. I thought the properly regenerated
>> configure had been committed. But I guess not.
>>
>> I am OK with the patch since or1k-rtems is in the same place but wanted
>> to note that the generated file had extra stuff in it for a good reason.
> We really should regenerate configure first, and then apply Chung-Ju's
> patch next. There will come a day when we will be reverting that
> patch, since hopefully GDB will be building for that target, one day.
> We don't want the revert to accidently also revert the bits that
> that resync configure with present-day configure.ac.
>
Please regenerate it and commit it. I posted asking for that a few weeks
ago. It is a top level configure and someone who touches it more routinely
should do it.

-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985

top-level configure regenerated (was: "Re: [PATCH, nds32] Exclude building gdb for nds32*-*-* target.")

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

> Please regenerate it and commit it. I posted asking for that a few
> weeks ago. It is a top level configure and someone who touches it more
> routinely should do it.

That's really quick and easy to do, so I've done it (patch attached).
But I also think that it's the same as any other configure script
regeneration, so anyone hacking configure scripts should feel free
to do it as well. Usually, reviewing the differences introduced during
the regeneration is sufficient to be confident about the update.

ChangeLog:

        * configure: Regenerate.

-- 
Joel

[-- Attachment #2: 0001-Regenerate-top-level-configure.patch --]
[-- Type: text/x-diff, Size: 1498 bytes --]

From f8797b5ad9aa357d80578ce020e95f1c43de7c9a Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Fri, 5 Sep 2014 12:19:56 -0700
Subject: [PATCH] Regenerate top-level configure.

Our top-level configure somehow got out of sync the current
configure.ac, so this patch regenerates it.

ChangeLog:

	* configure: Regenerate.
---
 ChangeLog | 4 ++++
 configure | 8 ++++----
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e9be42b..e668542 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2014-09-05  Joel Brobecker  <brobecker@adacore.com>
+
+	* configure: Regenerate.
+
 2014-08-27  Will Newton  <will.newton@linaro.org>
 
 	* src-release.sh: New file.
diff --git a/configure b/configure
index 26c9886..9fc1c88 100755
--- a/configure
+++ b/configure
@@ -3369,10 +3369,6 @@ case "${target}" in
     ;;
   *-*-rtems*)
     noconfigdirs="$noconfigdirs ${libgcj}"
-    # this is not caught below because this stanza matches earlier
-    case $target in
-      or1k*-*-*) noconfigdirs="$noconfigdirs gdb" ;;
-    esac
     ;;
   *-*-tpf*)
     noconfigdirs="$noconfigdirs ${libgcj}"
@@ -3607,6 +3603,10 @@ case "${target}" in
     ;;
   *-*-rtems*)
     noconfigdirs="$noconfigdirs target-libgloss"
+    # this is not caught below because this stanza matches earlier
+    case $target in
+      or1k*-*-*) noconfigdirs="$noconfigdirs gdb" ;;
+    esac
     ;;
     # The tpf target doesn't support gdb yet.
   *-*-tpf*)
-- 
1.9.1

Re: [PATCH, nds32] Exclude building gdb for nds32*-*-* target.

[Chung-Ju Wu]

[-- Attachment #1: Type: text/plain, Size: 1512 bytes --]

2014-09-06 3:10 GMT+08:00 Joel Sherrill <joel.sherrill@oarcorp.com>:
>
> On 9/5/2014 12:00 PM, Joel Brobecker wrote:
>>>> 2014-09-05  Chung-Ju Wu  <jasonwucj@gmail.com>
>>>>
>>>>     * configure.ac (nds32*-*-*): Disable gdb.
>>>>     * configure: Regenerated.
>>> It looks like the part for not building gdb for or1k*-*-rtems* gets moved
>>> by this patch.  I know there was an issue with the initial submission of
>>> that change.
>>>
>>> Your patch appears to correct that also. I thought the properly regenerated
>>> configure had been committed. But I guess not.
>>>
>>> I am OK with the patch since or1k-rtems is in the same place but wanted
>>> to note that the generated file had extra stuff in it for a good reason.
>> We really should regenerate configure first, and then apply Chung-Ju's
>> patch next. There will come a day when we will be reverting that
>> patch, since hopefully GDB will be building for that target, one day.
>> We don't want the revert to accidently also revert the bits that
>> that resync configure with present-day configure.ac.
>>

Thank you for clarifying it.  That also makes sense to me. :)

Since you have done the configure regeneration in
https://sourceware.org/ml/gdb-patches/2014-09/msg00155.html ,
I have my patch updated as attached and ChangeLog is the same as follow:


2014-09-05  Chung-Ju Wu  <jasonwucj@gmail.com>

        * configure.ac (nds32*-*-*): Disable gdb.
        * configure: Regenerated.


Is the updated patch OK to commit?


Best regards,
jasonwucj

[-- Attachment #2: 0001-Disable-gdb-for-nds32-until-it-is-supported_v2.patch --]
[-- Type: application/octet-stream, Size: 968 bytes --]

From f42298a43b671f27b1c2f8891bb458b03fb5bc37 Mon Sep 17 00:00:00 2001
From: Chung-Ju Wu <jasonwucj@gmail.com>
Date: Sat, 6 Sep 2014 03:54:47 +0800
Subject: [PATCH] Disable gdb for nds32*-*-* until it is supported.

---
 configure    | 3 +++
 configure.ac | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/configure b/configure
index 9fc1c88..dfea3bd 100755
--- a/configure
+++ b/configure
@@ -3805,6 +3805,9 @@ case "${target}" in
   mips*-*-*)
     noconfigdirs="$noconfigdirs gprof"
     ;;
+  nds32*-*-*)
+    noconfigdirs="$noconfigdirs gdb"
+    ;;
   or1k*-*-*)
     noconfigdirs="$noconfigdirs gdb"
     ;;
diff --git a/configure.ac b/configure.ac
index 028cbda..dada090 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1133,6 +1133,9 @@ case "${target}" in
   mips*-*-*)
     noconfigdirs="$noconfigdirs gprof"
     ;;
+  nds32*-*-*)
+    noconfigdirs="$noconfigdirs gdb"
+    ;;
   or1k*-*-*)
     noconfigdirs="$noconfigdirs gdb"
     ;;
-- 
1.8.1.1

Re: [PATCH, nds32] Exclude building gdb for nds32*-*-* target.

[Joel Brobecker]

> 2014-09-05  Chung-Ju Wu  <jasonwucj@gmail.com>
> 
>         * configure.ac (nds32*-*-*): Disable gdb.
>         * configure: Regenerated.
> 
> Is the updated patch OK to commit?

Thank you. Please go ahead and push.

-- 
Joel