From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12570 invoked by alias); 30 Mar 2015 14:14:42 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 12554 invoked by uid 89); 30 Mar 2015 14:14:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-pa0-f52.google.com Received: from mail-pa0-f52.google.com (HELO mail-pa0-f52.google.com) (209.85.220.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 30 Mar 2015 14:14:41 +0000 Received: by padcy3 with SMTP id cy3so168278287pad.3 for ; Mon, 30 Mar 2015 07:14:39 -0700 (PDT) X-Received: by 10.66.227.169 with SMTP id sb9mr60026755pac.11.1427724879556; Mon, 30 Mar 2015 07:14:39 -0700 (PDT) Received: from bubble.grove.modra.org (CPE-58-160-155-134.oycza5.sa.bigpond.net.au. [58.160.155.134]) by mx.google.com with ESMTPSA id wt1sm10848894pbc.76.2015.03.30.07.14.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Mar 2015 07:14:38 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 80E77EA0174; Tue, 31 Mar 2015 00:44:33 +1030 (ACDT) Date: Mon, 30 Mar 2015 14:14:00 -0000 From: Alan Modra To: "H.J. Lu" Cc: Binutils Subject: Re: [PATCH] Reduce file size for PT_GNU_RELRO segment Message-ID: <20150330141433.GL26234@bubble.grove.modra.org> Mail-Followup-To: "H.J. Lu" , Binutils References: <20150319130244.GA22592@intel.com> <20150326022246.GU26234@bubble.grove.modra.org> <20150328041540.GE26234@bubble.grove.modra.org> <20150329034858.GH26234@bubble.grove.modra.org> <20150330123934.GJ26234@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00444.txt.bz2 On Mon, Mar 30, 2015 at 06:00:20AM -0700, H.J. Lu wrote: > On Mon, Mar 30, 2015 at 5:39 AM, Alan Modra wrote: > > On Sun, Mar 29, 2015 at 06:58:45AM -0700, H.J. Lu wrote: > >> On Sat, Mar 28, 2015 at 8:48 PM, Alan Modra wrote: > >> > lang_size_sections). I think it important that we keep the relro base > >> > alignment code all in one place. > >> > >> It is not about the base alignment. It is about setting the address of > >> the first section in PT_GNU_RELRO segment, given the addresses > >> of PT_GNU_RELRO segment. It is impossible to set address of the first > >> section in PT_GNU_RELRO segment from lang_size_sections. > > > > Look again at the code for exp_dataseg_relro_adjust. If you change > > expld.dataseg.base there you will change addresses of sections in the > > relro segment. > > But I don't want to change expld.dataseg.base. I just want to > bump the address of the first section a bit. This says to me that you haven't analyzed the current relro code. That gives me no confidence that your patch is good for more that just the testcase you submitted. It's clear to me that it will interact with the existing exp_dataseg_relro_adjust code, perhaps badly in some cases. I'm not going to OK a patch that makes the relro code even more difficult to maintain. -- Alan Modra Australia Development Lab, IBM