From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40482 invoked by alias); 2 Mar 2016 03:16:27 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 37601 invoked by uid 89); 2 Mar 2016 03:12:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1120 X-HELO: mail-pf0-f175.google.com Received: from mail-pf0-f175.google.com (HELO mail-pf0-f175.google.com) (209.85.192.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 02 Mar 2016 03:12:04 +0000 Received: by mail-pf0-f175.google.com with SMTP id 124so63155094pfg.0 for ; Tue, 01 Mar 2016 19:12:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=H0azWpmFPkHH+h+TtjUOfSzctAVAvJHUoM8K820r9yE=; b=Al/J/IhWdSwGalELl4VVKiIIU90mD6QK6EJ9JkXxhw5qjHRJBOv6BPjZ8qnAdTNir2 V1ocp1GsdlMsnFUPqYkLvSQDZ1S4QkdsCcvRjH/MIKtVylUD8GMAS4emSqsv9JHlf5u0 hBHFfWF2SDmqTzgP5sBPRVpIK3E8WJ0r307i5hMF6V2Lqw8MD129c+Q720VBZEA3VVEr oW7ZiMc48U/ZHeSwE8zZemfaMQ+SIusQ90zFzKYT8zAsuRqCxLlG7jcpWC0lj3svP9Xa cp2ewU2qjK5BzrVfp6wACPsipDZK3eIsuMfBiaf1XI3rxAsrhtaUycIX6jToO/KcTMIk yKgw== X-Gm-Message-State: AD7BkJJvuJJBhPpVDfAH7KZ+ZTv0eS4Qw2sKDWYe00wo21ni5rHhB91/IKTjGH9Ts8TaVA== X-Received: by 10.98.33.67 with SMTP id h64mr29735159pfh.157.1456888322963; Tue, 01 Mar 2016 19:12:02 -0800 (PST) Received: from bubble.grove.modra.org (CPE-58-160-146-233.sa.bigpond.net.au. [58.160.146.233]) by smtp.gmail.com with ESMTPSA id wx3sm47023633pab.25.2016.03.01.19.12.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Mar 2016 19:12:02 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 13444EA0157; Wed, 2 Mar 2016 13:41:58 +1030 (ACDT) Date: Wed, 02 Mar 2016 03:16:00 -0000 From: Alan Modra To: binutils@sourceware.org Subject: Fix shift left warning at source Message-ID: <20160302031157.GT10657@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00021.txt.bz2 Nick's fix to fr30-ibld.c disappears when regenerating cgen files. cpu/ * fr30.cpu (f-m4): Replace -1 << 4 with -16. opcodes/ * fr30-ibld.c: Regenerate. diff --git a/cpu/fr30.cpu b/cpu/fr30.cpu index 6c8e8ce..0124647 100644 --- a/cpu/fr30.cpu +++ b/cpu/fr30.cpu @@ -163,7 +163,7 @@ ; ??? On a 64 bit host this doesn't get completely sign extended ; if the value is recorded in a long, as it is during extraction. ; Various fixes exist, pick one. - ((value pc) (or WI value (sll WI (const -1) (const 4)))) + ((value pc) (or WI value (const -16))) ) (dnf f-u8 "8 bit unsigned" () 8 8) (dnf f-i8 "8 bit unsigned" () 4 8) diff --git a/opcodes/fr30-ibld.c b/opcodes/fr30-ibld.c index 1293e73..3ebecf9 100644 --- a/opcodes/fr30-ibld.c +++ b/opcodes/fr30-ibld.c @@ -881,7 +881,7 @@ fr30_cgen_extract_operand (CGEN_CPU_DESC cd, { long value; length = extract_normal (cd, ex_info, insn_value, 0, 0, 8, 4, 16, total_length, pc, & value); - value = ((value) | (((-1UL) << (4)))); + value = ((value) | (-16)); fields->f_m4 = value; } break; -- 2.1.0 -- Alan Modra Australia Development Lab, IBM