public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: Missing TO_ADDR
Date: Wed, 30 Mar 2016 07:32:00 -0000	[thread overview]
Message-ID: <20160330073151.GK15812@bubble.grove.modra.org> (raw)

Calculates the wrong end address on targets with octets_per_byte
not equal to one.

	* ldlang.c (lang_size_sections_1): Correct code detecting a
	backward non-overlapping move.

diff --git a/ld/ldlang.c b/ld/ldlang.c
index 235a246..b369f99 100644
--- a/ld/ldlang.c
+++ b/ld/ldlang.c
@@ -5068,7 +5068,7 @@ lang_size_sections_1
 		   create overlapping LMAs.  */
 		if (dot < last->vma
 		    && os->bfd_section->size != 0
-		    && dot + os->bfd_section->size <= last->vma)
+		    && dot + TO_ADDR (os->bfd_section->size) <= last->vma)
 		  {
 		    /* If dot moved backwards then leave lma equal to
 		       vma.  This is the old default lma, which might

-- 
Alan Modra
Australia Development Lab, IBM

             reply	other threads:[~2016-03-30  7:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30  7:32 Alan Modra [this message]
2016-03-30 12:08 ` Dan
     [not found] ` <1459339484.9097.134.camel@jericho>
2016-03-31  7:40   ` Alan Modra
2016-03-31 11:13     ` Dan
2016-04-01  1:28       ` Alan Modra
2016-03-31 16:03     ` Dan
2016-04-01  1:31       ` Alan Modra
2016-04-01 14:42         ` [PATCH] " Dan
2016-04-08  5:16           ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330073151.GK15812@bubble.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).