public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Trevor Saunders <tbsaunde@tbsaunde.org>
To: Jiong Wang <jiong.wang@foss.arm.com>
Cc: tbsaunde+binutils@tbsaunde.org, binutils@sourceware.org
Subject: Re: [PATCH 7/7] enable -Wwrite-strings for gas
Date: Fri, 01 Apr 2016 12:17:00 -0000	[thread overview]
Message-ID: <20160401121938.GA23388@ball> (raw)
In-Reply-To: <56FE59CA.2040908@foss.arm.com>

On Fri, Apr 01, 2016 at 12:21:46PM +0100, Jiong Wang wrote:
> 
> On 30/03/16 02:13, tbsaunde+binutils@tbsaunde.org wrote:
> >From: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
> >
> >We add a new AC_SUBST to warning.m4 so that the test if the warning is
> >supported is centralized, but the warning can be enabled per directory.
> >
> >binutils/ChangeLog:
> >
> >2016-03-29  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
> >
> >	* configure: Regenerate.
> >
> >gprof/ChangeLog:
> >
> >2016-03-29  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
> >
> >	* configure: Regenerate.
> >
> >ld/ChangeLog:
> >
> >2016-03-29  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
> >
> >	* configure: Regenerate.
> >
> >opcodes/ChangeLog:
> >
> >2016-03-29  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
> >
> >	* configure: Regenerate.
> >
> >bfd/ChangeLog:
> >
> >2016-03-29  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
> >
> >	* configure: Regenerate.
> >	* warning.m4: Add WARN_WRITE_STRINGS AC_SUBST.
> >
> >gold/ChangeLog:
> >
> >2016-03-29  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
> >
> >	* configure: Regenerate.
> >
> >gas/ChangeLog:
> >
> >2016-03-29  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
> >
> >	* Makefile.am: Add WARN_WRITE_STRINGS to WARN_CFLAGS.
> >	* Makefile.in: Regenerate.
> >	* configure: Likewise.
> 
> 
> This caused build failures when binutils-gdb is configured with
> --disable-nls, for example:
> 
> ../configure --disable-nls
> make
> 
> 
> ../../binutils-gdb-commit/gas/expr.c: In function ‘expr’:
> ../../binutils-gdb-commit/gas/expr.c:1919:8: error: passing argument 1 of
> ‘as_warn_value_out_of_range’ discards ‘const’ qualifier from pointer target
> type [-Werror]
>         NULL, 0);

bleh, it looks like asintl.h does
#define _(string) (string)
which isn't compatible with the standard prototype of gettext().  I
expect adding a cast there should fix it, though maybe you need to fix a
couple other macros there?  I'll start testing that in a few minutes.

sorry about the breakage.

Trev

> 

  reply	other threads:[~2016-04-01 12:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30  1:08 [PATCH 0/7] " tbsaunde+binutils
2016-03-30  1:08 ` [PATCH 3/7] cast to char * when assigning to optarg tbsaunde+binutils
2016-03-30  1:08 ` [PATCH 2/7] work around get_symbol_name () in sparc and ia64 tbsaunde+binutils
2016-03-30  1:08 ` [PATCH 1/7] cast literal to char * when assigning to input_line_ptr tbsaunde+binutils
2016-03-30  1:08 ` [PATCH 7/7] enable -Wwrite-strings for gas tbsaunde+binutils
2016-04-01 11:22   ` Jiong Wang
2016-04-01 12:17     ` Trevor Saunders [this message]
2016-04-01 12:40     ` Alan Modra
2016-04-01 13:10       ` Trevor Saunders
2016-03-30  1:08 ` [PATCH 5/7] tc-i960.c: add some casts when assigning literals to args[i] tbsaunde+binutils
2016-03-30  1:14 ` [PATCH 6/7] make xtensa_section_rename () take const char * tbsaunde+binutils
2016-03-30  1:14 ` [PATCH 4/7] cast the arg to md_assemble () to " tbsaunde+binutils
2016-03-31 10:34 ` [PATCH 0/7] enable -Wwrite-strings for gas Alan Modra
2016-05-01 16:44 ` Andrew Pinski
2016-05-02 18:25   ` Trevor Saunders
2016-05-02 19:38     ` Andrew Pinski
2016-05-03  8:12       ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160401121938.GA23388@ball \
    --to=tbsaunde@tbsaunde.org \
    --cc=binutils@sourceware.org \
    --cc=jiong.wang@foss.arm.com \
    --cc=tbsaunde+binutils@tbsaunde.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).