From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34190 invoked by alias); 1 Apr 2016 12:17:06 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 34172 invoked by uid 89); 1 Apr 2016 12:17:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2087, HContent-Transfer-Encoding:8bit X-HELO: paperclip.tbsaunde.org Received: from tbsaunde.org (HELO paperclip.tbsaunde.org) (66.228.47.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Apr 2016 12:16:54 +0000 Received: from ball (unknown [23.233.68.71]) by paperclip.tbsaunde.org (Postfix) with ESMTPSA id 9A6DDC06B; Fri, 1 Apr 2016 12:16:52 +0000 (UTC) Date: Fri, 01 Apr 2016 12:17:00 -0000 From: Trevor Saunders To: Jiong Wang Cc: tbsaunde+binutils@tbsaunde.org, binutils@sourceware.org Subject: Re: [PATCH 7/7] enable -Wwrite-strings for gas Message-ID: <20160401121938.GA23388@ball> References: <1459300381-19313-1-git-send-email-tbsaunde+binutils@tbsaunde.org> <1459300381-19313-8-git-send-email-tbsaunde+binutils@tbsaunde.org> <56FE59CA.2040908@foss.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56FE59CA.2040908@foss.arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2016-04/txt/msg00003.txt.bz2 On Fri, Apr 01, 2016 at 12:21:46PM +0100, Jiong Wang wrote: > > On 30/03/16 02:13, tbsaunde+binutils@tbsaunde.org wrote: > >From: Trevor Saunders > > > >We add a new AC_SUBST to warning.m4 so that the test if the warning is > >supported is centralized, but the warning can be enabled per directory. > > > >binutils/ChangeLog: > > > >2016-03-29 Trevor Saunders > > > > * configure: Regenerate. > > > >gprof/ChangeLog: > > > >2016-03-29 Trevor Saunders > > > > * configure: Regenerate. > > > >ld/ChangeLog: > > > >2016-03-29 Trevor Saunders > > > > * configure: Regenerate. > > > >opcodes/ChangeLog: > > > >2016-03-29 Trevor Saunders > > > > * configure: Regenerate. > > > >bfd/ChangeLog: > > > >2016-03-29 Trevor Saunders > > > > * configure: Regenerate. > > * warning.m4: Add WARN_WRITE_STRINGS AC_SUBST. > > > >gold/ChangeLog: > > > >2016-03-29 Trevor Saunders > > > > * configure: Regenerate. > > > >gas/ChangeLog: > > > >2016-03-29 Trevor Saunders > > > > * Makefile.am: Add WARN_WRITE_STRINGS to WARN_CFLAGS. > > * Makefile.in: Regenerate. > > * configure: Likewise. > > > This caused build failures when binutils-gdb is configured with > --disable-nls, for example: > > ../configure --disable-nls > make > > > ../../binutils-gdb-commit/gas/expr.c: In function ‘expr’: > ../../binutils-gdb-commit/gas/expr.c:1919:8: error: passing argument 1 of > ‘as_warn_value_out_of_range’ discards ‘const’ qualifier from pointer target > type [-Werror] > NULL, 0); bleh, it looks like asintl.h does #define _(string) (string) which isn't compatible with the standard prototype of gettext(). I expect adding a cast there should fix it, though maybe you need to fix a couple other macros there? I'll start testing that in a few minutes. sorry about the breakage. Trev >