From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: PR19498, Invalid "symbol definition loop"
Date: Mon, 04 Apr 2016 07:05:00 -0000 [thread overview]
Message-ID: <20160404070530.GA18129@bubble.grove.modra.org> (raw)
Applied. Fixes a bug that's been around since 2005-10-24.
PR 19498
* symbols.c (resolve_symbol_value): Clear sy_resolving on exit
from function on all paths that set sy_resolving.
diff --git a/gas/symbols.c b/gas/symbols.c
index 642f6d7..4c3137a 100644
--- a/gas/symbols.c
+++ b/gas/symbols.c
@@ -1262,7 +1262,10 @@ resolve_symbol_value (symbolS *symp)
resolved = symbol_resolved_p (add_symbol);
if (S_IS_WEAKREFR (symp))
- goto exit_dont_set_value;
+ {
+ symp->sy_flags.sy_resolving = 0;
+ goto exit_dont_set_value;
+ }
break;
case O_uminus:
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2016-04-04 7:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404070530.GA18129@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).