From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123374 invoked by alias); 5 Apr 2016 23:50:50 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 123351 invoked by uid 89); 5 Apr 2016 23:50:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pa0-f44.google.com Received: from mail-pa0-f44.google.com (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 05 Apr 2016 23:50:47 +0000 Received: by mail-pa0-f44.google.com with SMTP id fe3so20282032pab.1 for ; Tue, 05 Apr 2016 16:50:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sXPRu1/8d/Vhb1/wTfJiGAeEKFOWld7HXeMbIqjMf28=; b=TNrhB8f3xj5xtvFInotJUc41CV1c0PNno7z2plY7t0H8yDUKFAhRXupSZmx9RowHic piTqyxM7vWnTRlrE7PG7W6ujAc/iCIk/WovGZEGhfm40zoLAWQGVe2mdGHiyLG5Vk55p tdPFmRxkNs0tCuSn1L64F0kelday0M9N1gh7carBMMc6xc8MOHyEyS3ZoUv8RqJ5nwWp XvgqMN/dDqASapFxSZSAQwPlf6qoadJ3rjNemCb1JrsPEoTENkogjzkYgcdwfa8tqqFw F9NBvgcpa5Dc5vkzDhc1KbYoBrYuO7cwWbVOqlU1nMbzEURfOOzpdyg1kt43XJeP+wGm Xprg== X-Gm-Message-State: AD7BkJIntU3V+FceVox0xo9uMuB1jYYRTj44Gpp4d2z4Z/9mJuX29XDb/HDmzPisauOBhw== X-Received: by 10.66.254.71 with SMTP id ag7mr66278896pad.121.1459900246218; Tue, 05 Apr 2016 16:50:46 -0700 (PDT) Received: from bubble.grove.modra.org (CPE-58-160-146-233.sa.bigpond.net.au. [58.160.146.233]) by smtp.gmail.com with ESMTPSA id 85sm136891pfl.18.2016.04.05.16.50.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Apr 2016 16:50:45 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 15136EA0153; Wed, 6 Apr 2016 09:20:41 +0930 (ACST) Date: Tue, 05 Apr 2016 23:50:00 -0000 From: Alan Modra To: Thomas Preudhomme Cc: "binutils@sourceware.org" , "nickc@redhat.com" Subject: Re: [PATCH, binutils/ARM] Fix leak of local internal symbols in elf32_arm_size_stubs Message-ID: <20160405235040.GE18129@bubble.grove.modra.org> References: <002501d10adf$89816b40$9c8441c0$@arm.com> <5630E1DC.9080306@redhat.com> <20151029000444.GG13961@bubble.grove.modra.org> <4013675.oZOsPRMpWM@e108577-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4013675.oZOsPRMpWM@e108577-lin> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00094.txt.bz2 On Tue, Apr 05, 2016 at 06:00:30PM +0100, Thomas Preudhomme wrote: > * elf32-arm.c (elf32_arm_size_stubs): Move error_ret_free_local to be > a fall through from error_ret_free_internal. Free local_syms in > error_ret_free_local if allocated from bfd_elf_get_elf_syms (). Looks good. -- Alan Modra Australia Development Lab, IBM