From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Alan Modra <amodra@gmail.com>
Cc: Claudiu.Zissulescu@synopsys.com, binutils@sourceware.org
Subject: Re: [PATCH] ld/arc: Fix linker for big-endian arc targets
Date: Thu, 07 Apr 2016 15:22:00 -0000 [thread overview]
Message-ID: <20160407152205.GP25615@embecosm.com> (raw)
In-Reply-To: <20160407140659.GL18129@bubble.grove.modra.org>
* Alan Modra <amodra@gmail.com> [2016-04-07 23:36:59 +0930]:
> On Tue, Apr 05, 2016 at 03:00:48PM +0100, Nick Clifton wrote:
> > > * emulparams/arc-endianness.sh: New file.
> > > * emulparams/arcebelf.sh: Deleted.
> > > * emulparams/arcebelf_prof.sh: Deleted.
> > > * emulparams/arceblinux.sh: Deleted.
> > > * emulparams/arceblinux_prof.sh: Deleted.
> > > * emulparams/arcelf.sh: Include arc-endinness.sh.
> > > * emulparams/arcelf_prof.sh: Include arc-endinness.sh.
> > > * emulparams/arclinux.sh: Include arc-endinness.sh.
> > > * emulparams/arclinux_prof.sh: Include arc-endinness.sh.
> > > * emulparams/arcv2elf.sh: Include arc-endinness.sh.
> > > * emulparams/arcv2elfx.sh: Include arc-endinness.sh.
>
> It's likely that the above is responsible for breaking
> --enable-targets=all builds. Please fix.
Sorry about that, the patch below should fix things. OK to apply?
Thanks,
Andrew
---
ld/arc: Make little endian default choice for linker scripts
When building with --enable-targets=all the target string is not set to
something that matches the pattern arc*-*, and so the script used to
decide if we should build big or little endian linker script currently
exits with an error.
This commit makes little endian linker script be the default, which will
be used when building for all targets, this matches the behaviour from
before I made the endianness switchable, when we only ever built little
endian linker scripts anyway.
ld/ChangeLog:
* emulparams/arc-endianness.sh: Make little endian default choice.
diff --git a/ld/emulparams/arc-endianness.sh b/ld/emulparams/arc-endianness.sh
index 4d6158b..7a66dee 100644
--- a/ld/emulparams/arc-endianness.sh
+++ b/ld/emulparams/arc-endianness.sh
@@ -1,10 +1,11 @@
+# Select an appropriate endinaness based on the value of target. When
+# building for all targets we select little endian, which is what the
+# '*' pattern is for.
case ${target} in
arceb-*)
ARC_ENDIAN="big"
;;
- arc-*)
+ arc-* | * )
ARC_ENDIAN="little"
;;
- *)
- exit 1
esac
next prev parent reply other threads:[~2016-04-07 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 16:34 Andrew Burgess
2016-04-03 8:38 ` Cupertino Miranda
2016-04-05 14:01 ` Nick Clifton
2016-04-07 14:07 ` Alan Modra
2016-04-07 15:20 ` Claudiu Zissulescu
2016-04-07 15:22 ` Andrew Burgess [this message]
2016-04-07 15:33 ` Claudiu Zissulescu
2016-04-07 15:50 ` [PUSHED] " Andrew Burgess
2016-04-07 15:42 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407152205.GP25615@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=Claudiu.Zissulescu@synopsys.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).