[PATCH] remove some unused globals

[PATCH] remove some unused globals

[tbsaunde+binutils]

From: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>

hi,

$subject, built crosses to msp430-elf and m32c-elf, ok?

Trev

gas/ChangeLog:

2016-04-12  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>

	* config/tc-m32c.c (M32C_Macros): Remove.
	* config/tc-msp430.c (option_numbers): Likewise.
---
 gas/config/tc-m32c.c   | 2 +-
 gas/config/tc-msp430.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gas/config/tc-m32c.c b/gas/config/tc-m32c.c
index 70f0aeb..b28797b 100644
--- a/gas/config/tc-m32c.c
+++ b/gas/config/tc-m32c.c
@@ -475,7 +475,7 @@ enum {
   M32C_MACRO_ADJNZ_3,
   M32C_MACRO_ADJNZ_4,
   M32C_MACRO_ADJNZ_5,
-} M32C_Macros;
+};
 
 static struct {
   int insn;
diff --git a/gas/config/tc-msp430.c b/gas/config/tc-msp430.c
index f9df729..8e95b1d 100644
--- a/gas/config/tc-msp430.c
+++ b/gas/config/tc-msp430.c
@@ -684,7 +684,7 @@ enum
 {
   OPTION_SILICON_ERRATA = OPTION_MD_BASE,
   OPTION_SILICON_ERRATA_WARN,
-} option_numbers;
+};
 
 static unsigned int silicon_errata_fix = 0;
 static unsigned int silicon_errata_warn = 0;
-- 
2.1.4

Re: [PATCH] remove some unused globals

[Nick Clifton]

Hi Trev,

> $subject, built crosses to msp430-elf and m32c-elf, ok?

If you make these enums anonymous, doesn't that make them harder to use/reference from a debugger ?

Cheers
  Nick

Re: [PATCH] remove some unused globals

[Trevor Saunders]

On Tue, Apr 12, 2016 at 05:25:10PM +0100, Nick Clifton wrote:
> Hi Trev,
> 
> > $subject, built crosses to msp430-elf and m32c-elf, ok?
> 
> If you make these enums anonymous, doesn't that make them harder to use/reference from a debugger ?

I'm not sure I follow, these enums have always been anonymous in the
sense you can't name there type.  So it used to be we declared a set of
constants in the { } and then declared a variable of some anonymous enum
type, but then we never used that variable and only used the enum
constants with other variables.  So I expect the only difference this
makes to debugging is that you can't refer to a variable that doesn't
exist, but since that variable never does anything examining it seems
pointless.

Now it may well be that naming these types, and changing some variables
from type int to the enum type would improve debugging by getting gdb to
just print the constant name, but I don't think anything is regressed
here.  Looking a little deeper it seems like in the msp430 it might be
clearer to just use a bool or something.

Thanks!

Trev

> 
> Cheers
>   Nick

Re: [PATCH] remove some unused globals

[Nick Clifton]

Hi Trev,

> 2016-04-12  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
> 
> 	* config/tc-m32c.c (M32C_Macros): Remove.
> 	* config/tc-msp430.c (option_numbers): Likewise.

Approved - please apply.

(I tried to construct a GDB based scenario where this change would be 
a problem, but failed utterly... :-)

Cheers
  Nick