public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>,
	binutils@sourceware.org
Subject: Re: [binutils-gdb] remove pointless assignment
Date: Sat, 23 Apr 2016 14:31:00 -0000	[thread overview]
Message-ID: <20160423143108.GF27353@bubble.grove.modra.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1604190151540.21846@tp.orcam.me.uk>

On Fri, Apr 22, 2016 at 07:28:45PM +0100, Maciej W. Rozycki wrote:
>  Why did you commit this change without a review?  I saw Alan made some 
> suggestions on top of your original submission, but he didn't say a change 
> with these updates was preapproved

That was my intent, if not my exact wording.  I'm sorry if I erred in
reviewing the patch.

-- 
Alan Modra
Australia Development Lab, IBM

  reply	other threads:[~2016-04-23 14:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160416011534.2268.qmail@sourceware.org>
2016-04-22 18:29 ` Maciej W. Rozycki
2016-04-23 14:31   ` Alan Modra [this message]
2016-04-23 18:27     ` Trevor Saunders
2016-04-25 14:04       ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160423143108.GF27353@bubble.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=macro@imgtec.com \
    --cc=tbsaunde+binutils@tbsaunde.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).