From: Alan Modra <amodra@gmail.com>
To: Trevor Saunders <tbsaunde@tbsaunde.org>
Cc: tbsaunde+binutils@tbsaunde.org, binutils@sourceware.org
Subject: Re: [PATCH] use xstrdup and concat more
Date: Wed, 27 Apr 2016 11:59:00 -0000 [thread overview]
Message-ID: <20160427115853.GA16516@bubble.grove.modra.org> (raw)
In-Reply-To: <20160427101949.GA6733@tsaunders-iceball.corp.tor1.mozilla.com>
On Wed, Apr 27, 2016 at 06:20:53AM -0400, Trevor Saunders wrote:
> > +static inline void *
> > +xmemdup0 (const void *in, size_t len)
> > +{
> > + char *out = (char *) xmalloc (len + 1);
> > + out[len] = 0;
> > + return memcpy (out, in, len);
>
> Given we always use this with strings, and null terminating other things
> with 1 zero byte doesn't seem to make a lot of sense should this return
> char *? I can make that change with my patch if you agree.
I chose void * to be like xmemdup, but as you say, the function will
probably only be used to copy strings. Feel free to change the param
and result to char * (and cast memcpy result).
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2016-04-27 11:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 7:38 tbsaunde+binutils
2016-04-25 8:40 ` Nick Clifton
2016-04-25 13:01 ` Alan Modra
2016-04-25 13:56 ` Trevor Saunders
2016-04-25 14:56 ` Alan Modra
2016-04-26 23:52 ` Trevor Saunders
2016-04-27 6:19 ` Alan Modra
2016-04-27 10:21 ` Trevor Saunders
2016-04-27 11:59 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427115853.GA16516@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=tbsaunde+binutils@tbsaunde.org \
--cc=tbsaunde@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).