From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55093 invoked by alias); 25 May 2016 00:33:17 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 54753 invoked by uid 89); 25 May 2016 00:33:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=news X-HELO: mail-pa0-f67.google.com Received: from mail-pa0-f67.google.com (HELO mail-pa0-f67.google.com) (209.85.220.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 25 May 2016 00:33:15 +0000 Received: by mail-pa0-f67.google.com with SMTP id fg1so3477204pad.3 for ; Tue, 24 May 2016 17:33:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vieCKa4544cS/xUjWJ+5KUAb/wQfHRVjVqiMamdhn0A=; b=LGmtmwmtOmj1qDiAKeFd3ltkqj8mAmTtQ2rrc+xmaghS++/AM42q5FmETYRh4a0LkR 2/SfPJAMnCVL8FqFpRGJSrGjIPdQGuDMehMILkd8jfVwLdwjVLZxxdH5y7hm6DRKypKd pOpvkVJ1ywnBBOydCWKO6g7IX60nFbR9y9Zb7Pic2qCkXGfmAnW6Obfd6KeUdMvxoFz6 7TSrXJc1ZoHIMLjCzntRxwyEzVmaSs6ykhDqCt2u97N1HpaaKNVW5PRseVgyPzb0Pkn7 iw14rf+Xxl5pyeVOIz0W0v45ArAuF3E5cFLuafnUIj6cQzYpud1cLvbnW1+itCVsLee/ bmpA== X-Gm-Message-State: ALyK8tIAiU7pvo0I2vA+VJEqJDDbBMcAiJC5IDrXWEjDhqOopaRtELHWhOR95J3rtLSYaw== X-Received: by 10.66.25.236 with SMTP id f12mr1502671pag.35.1464136393472; Tue, 24 May 2016 17:33:13 -0700 (PDT) Received: from bubble.grove.modra.org (CPE-58-160-146-233.sa.bigpond.net.au. [58.160.146.233]) by smtp.gmail.com with ESMTPSA id t65sm40602165pfb.37.2016.05.24.17.33.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 May 2016 17:33:12 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id EEFBFEA0199; Wed, 25 May 2016 10:03:23 +0930 (ACST) Date: Wed, 25 May 2016 00:33:00 -0000 From: Alan Modra To: "H.J. Lu" Cc: Binutils Subject: Re: [PATCH] PR binutils/14625: Enable 64-bit archives in ar and ranlib Message-ID: <20160525003323.GG3300@bubble.grove.modra.org> References: <20160520121002.GA28605@intel.com> <20160523094203.GC3300@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00382.txt.bz2 On Tue, May 24, 2016 at 01:29:07PM -0700, H.J. Lu wrote: > bfd/ > > PR binutils/14625 > * archive.c (bfd_slurp_armap): Replace > bfd_elf64_archive_slurp_armap with > _bfd_archive_64_bit_slurp_armap. > (bsd_write_armap): Call _bfd_archive_64_bit_write_armap if > BFD64 is defined and the archive is too big. > (coff_write_armap): Likewise. > * archive64.c (bfd_elf64_archive_slurp_armap): Renamed to ... > (_bfd_archive_64_bit_slurp_armap): This. > (bfd_elf64_archive_write_armap): Renamed to ... > (_bfd_archive_64_bit_write_armap): This. > * configure.ac: Add --enable-64-bit-archive. > (want_64_bit_archive): New. Set to true by default for 64-bit > MIPS and s390 ELF targets. > (USE_64_BIT_ARCHIVE): New AC_DEFINE. > * config.in: Regenerated. > * configure: Likewise. > * elf64-mips.c (bfd_elf64_archive_functions): Removed. > (bfd_elf64_archive_slurp_armap): Likewise. > (bfd_elf64_archive_write_armap): Likewise. > (bfd_elf64_archive_slurp_extended_name_table): Likewise. > (bfd_elf64_archive_construct_extended_name_table): Likewise. > (bfd_elf64_archive_truncate_arname): Likewise. > (bfd_elf64_archive_read_ar_hdr): Likewise. > (bfd_elf64_archive_write_ar_hdr): Likewise. > (bfd_elf64_archive_openr_next_archived_file): Likewise. > (bfd_elf64_archive_get_elt_at_index): Likewise. > (bfd_elf64_archive_generic_stat_arch_elt): Likewise. > (bfd_elf64_archive_update_armap_timestamp): Likewise. > * elf64-s390.c (bfd_elf64_archive_functions): Removed. > (bfd_elf64_archive_slurp_armap): Likewise. > (bfd_elf64_archive_write_armap): Likewise. > (bfd_elf64_archive_slurp_extended_name_table): Likewise. > (bfd_elf64_archive_construct_extended_name_table): Likewise. > (bfd_elf64_archive_truncate_arname): Likewise. > (bfd_elf64_archive_read_ar_hdr): Likewise. > (bfd_elf64_archive_write_ar_hdr): Likewise. > (bfd_elf64_archive_openr_next_archived_file): Likewise. > (bfd_elf64_archive_get_elt_at_index): Likewise. > (bfd_elf64_archive_generic_stat_arch_elt): Likewise. > (bfd_elf64_archive_update_armap_timestamp): Likewise. > * elfxx-target.h (TARGET_BIG_SYM): Use _bfd_archive_64_bit on > BFD_JUMP_TABLE_ARCHIVE if USE_64_BIT_ARCHIVE is defined and > bfd_elfNN_archive_functions isn't defined. > (TARGET_LITTLE_SYM): Likewise. > * libbfd-in.h (_bfd_archive_64_bit_slurp_armap): New prototype. > (_bfd_archive_64_bit_write_armap): Likewise. > (_bfd_archive_64_bit_slurp_extended_name_table): New macro. > (_bfd_archive_64_bit_construct_extended_name_table): Likewise. > (_bfd_archive_64_bit_truncate_arname): Likewise. > (_bfd_archive_64_bit_read_ar_hdr): Likewise. > (_bfd_archive_64_bit_write_ar_hdr): Likewise. > (_bfd_archive_64_bit_openr_next_archived_file): Likewise. > (_bfd_archive_64_bit_get_elt_at_index): Likewise. > (_bfd_archive_64_bit_generic_stat_arch_elt): Likewise. > (_bfd_archive_64_bit_update_armap_timestamp): Likewise. > * libbfd.h: Regenerated. > * plugin.c (plugin_vec): Use _bfd_archive_64_bit on > BFD_JUMP_TABLE_ARCHIVE if USE_64_BIT_ARCHIVE is defined. > > binutils/ > > PR binutils/14625 > * NEWS: Mention --enable-64-bit-archive. OK, but > + /* The archive file format only has 4 bytes to store the offset > + of the member. Generate 64-bit archive if an archive past its > + 4Gb limit. */ Generate a 64-bit archive if an archive is past... > + /* Generate 64-bit archive if an archive past its 4Gb limit. */ Same. > +# Since the plugin target is used to create archive in plugin-enabled > +# ar, we need a way to enable 64-bit archives in the plugin target. Comment is now wrong, since you auto-detect whether a 64-bit archive format is needed. > --- a/binutils/NEWS > +++ b/binutils/NEWS > @@ -1,5 +1,8 @@ > -*- text -*- > > +* Add a configure option, --enable-64-bit-archive, to enable 64-bit > + archives in ar and ranlib. > + * Add a configure option, --enable-64-bit-archive, to force use of a 64-bit format when creating an archive symbol index. -- Alan Modra Australia Development Lab, IBM