From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Artemiy Volkov <artemiyv@acm.org>
Cc: Cary Coutant <ccoutant@gmail.com>,
Vladimir Radosavljevic <Vladimir.Radosavljevic@imgtec.com>,
"binutils@sourceware.org" <binutils@sourceware.org>,
Petar Jovanovic <Petar.Jovanovic@imgtec.com>
Subject: Re: [PATCH v4] gold: Fix non-deterministic behaviour of Mips gold.
Date: Wed, 25 May 2016 13:49:00 -0000 [thread overview]
Message-ID: <20160525134909.GA312@x4> (raw)
In-Reply-To: <CAOxjHa0aY2uFKCL-UPdQtQzkax_Y1F52k6WikCRta1nFi-O8KA@mail.gmail.com>
On 2016.05.25 at 10:50 +0300, Artemiy Volkov wrote:
> On Fri, May 20, 2016 at 1:09 AM, Cary Coutant <ccoutant@gmail.com> wrote:
> >> * mips.cc (Mips_got_entry::Mips_got_entry): Remove object argument
> > Committed with the suggested change. Revised patch attached.
> > -cary
>
> this patch breaks the gold build for me since not all callers of
> Mips_got_info::global_got_symbols() were adjusted to use the new
> return type.
>
> I have attached the easiest possible fix.
I ran into the same issue today.
Please just commit your fix, because I think the patch is obvious.
--
Markus
next prev parent reply other threads:[~2016-05-25 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 13:28 Vladimir Radosavljevic
2016-04-07 14:42 ` Cary Coutant
2016-04-07 14:52 ` Vladimir Radosavljevic
2016-05-04 13:23 ` Vladimir Radosavljevic
2016-05-09 4:53 ` Cary Coutant
2016-05-19 22:09 ` Cary Coutant
2016-05-25 7:51 ` Artemiy Volkov
2016-05-25 13:49 ` Markus Trippelsdorf [this message]
2016-06-09 18:43 ` Cary Coutant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525134909.GA312@x4 \
--to=markus@trippelsdorf.de \
--cc=Petar.Jovanovic@imgtec.com \
--cc=Vladimir.Radosavljevic@imgtec.com \
--cc=artemiyv@acm.org \
--cc=binutils@sourceware.org \
--cc=ccoutant@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).