* [PATCH] ARM: Fix elf32_arm_count_additional_relocs
@ 2016-09-22 1:52 Akihiko Odaki
2016-09-22 8:36 ` Renlin Li
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Akihiko Odaki @ 2016-09-22 1:52 UTC (permalink / raw)
To: binutils; +Cc: Paul Brook, Yury Usishchev, Akihiko Odaki
---
bfd/elf32-arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
index 3d4a458..5041dab 100644
--- a/bfd/elf32-arm.c
+++ b/bfd/elf32-arm.c
@@ -18172,7 +18172,7 @@ elf32_arm_count_additional_relocs (asection *sec)
{
struct _arm_elf_section_data *arm_data;
arm_data = get_arm_elf_section_data (sec);
- return arm_data->additional_reloc_count;
+ return arm_data ? arm_data->additional_reloc_count : 0;
}
/* Called to set the sh_flags, sh_link and sh_info fields of OSECTION which
--
2.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: Fix elf32_arm_count_additional_relocs
2016-09-22 1:52 [PATCH] ARM: Fix elf32_arm_count_additional_relocs Akihiko Odaki
@ 2016-09-22 8:36 ` Renlin Li
2016-09-23 4:40 ` [PATCH v2] " Akihiko Odaki
2016-09-23 10:25 ` [PATCH v4] ARM: Fix relocation of EXIDX sections Akihiko Odaki
2 siblings, 0 replies; 7+ messages in thread
From: Renlin Li @ 2016-09-22 8:36 UTC (permalink / raw)
To: Akihiko Odaki, binutils
Cc: Paul Brook, Yury Usishchev, Nicholas Clifton, Richard Earnshaw
Hi there,
get_arm_section_data () could return NULL in some cases. It would be
great if you give some explanations or provide a test case which this
can be triggered.
BTW you need to have a ChangeLog for the patch as well. You can find
examples from other patch emails.
CCed ARM target maintainer: Nick and Richard.
Regards,
Renlin
On 22/09/16 02:52, Akihiko Odaki wrote:
> ---
> bfd/elf32-arm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
> index 3d4a458..5041dab 100644
> --- a/bfd/elf32-arm.c
> +++ b/bfd/elf32-arm.c
> @@ -18172,7 +18172,7 @@ elf32_arm_count_additional_relocs (asection *sec)
> {
> struct _arm_elf_section_data *arm_data;
> arm_data = get_arm_elf_section_data (sec);
> - return arm_data->additional_reloc_count;
> + return arm_data ? arm_data->additional_reloc_count : 0;
> }
>
> /* Called to set the sh_flags, sh_link and sh_info fields of OSECTION which
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] ARM: Fix elf32_arm_count_additional_relocs
2016-09-22 1:52 [PATCH] ARM: Fix elf32_arm_count_additional_relocs Akihiko Odaki
2016-09-22 8:36 ` Renlin Li
@ 2016-09-23 4:40 ` Akihiko Odaki
2016-09-23 10:25 ` [PATCH v4] ARM: Fix relocation of EXIDX sections Akihiko Odaki
2 siblings, 0 replies; 7+ messages in thread
From: Akihiko Odaki @ 2016-09-23 4:40 UTC (permalink / raw)
To: binutils
Cc: Renlin Li, Paul Brook, Yury Usishchev, Nicholas Clifton,
Richard Earnshaw, Akihiko Odaki
---
bfd/elf32-arm.c | 2 +-
ld/ChangeLog | 7 +++++++
ld/testsuite/ld-arm/arm-elf.exp | 8 ++++++++
3 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
index 3d4a458..5041dab 100644
--- a/bfd/elf32-arm.c
+++ b/bfd/elf32-arm.c
@@ -18172,7 +18172,7 @@ elf32_arm_count_additional_relocs (asection *sec)
{
struct _arm_elf_section_data *arm_data;
arm_data = get_arm_elf_section_data (sec);
- return arm_data->additional_reloc_count;
+ return arm_data ? arm_data->additional_reloc_count : 0;
}
/* Called to set the sh_flags, sh_link and sh_info fields of OSECTION which
diff --git a/ld/ChangeLog b/ld/ChangeLog
index a251a21..f1574ef 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,10 @@
+2016-09-23 Akihiko Odaki <akihiko.odaki.4i@stu.hosei.ac.jp>
+
+ * elf32-arm.c (elf32_arm_count_additional_relocs): Check if the section
+ data exists.
+ * testsuite/arm-elf.exp: Expect to link even section without the section
+ data.
+
2016-09-06 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
Backport from mainline
diff --git a/ld/testsuite/ld-arm/arm-elf.exp b/ld/testsuite/ld-arm/arm-elf.exp
index a5d4c87..063abd3 100644
--- a/ld/testsuite/ld-arm/arm-elf.exp
+++ b/ld/testsuite/ld-arm/arm-elf.exp
@@ -989,3 +989,11 @@ set arm_unwind_tests {
"unwind-mix"}
}
run_ld_link_tests $arm_unwind_tests
+
+# Link section without a section data. Binary (-b binary) should not have a
+# section data and incremental linking (-r) will prevent from adding one.
+# Such a case should be concerned to eliminate the wrong assumption that the
+# section data always exists.
+if { ![ld_simple_link $ld raw "-b binary -r $srcdir/$subdir/arm-elf.exp"] } {
+ fail "raw section linking"
+}
--
2.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v4] ARM: Fix relocation of EXIDX sections
2016-09-22 1:52 [PATCH] ARM: Fix elf32_arm_count_additional_relocs Akihiko Odaki
2016-09-22 8:36 ` Renlin Li
2016-09-23 4:40 ` [PATCH v2] " Akihiko Odaki
@ 2016-09-23 10:25 ` Akihiko Odaki
2016-09-23 15:35 ` Nick Clifton
2016-09-26 9:40 ` Szabolcs Nagy
2 siblings, 2 replies; 7+ messages in thread
From: Akihiko Odaki @ 2016-09-23 10:25 UTC (permalink / raw)
To: binutils
Cc: Nick Clifton, Andreas Schwab, Paul Brook, Yury Usishchev, Akihiko Odaki
As reported in PR binutils/20595, BFD has a bug that it doesn't delete
relocations for deleted exidx. This change fixes the behavior.
bfd * elf-bfd.h: Add callback to count relocations in the final output.
* elf-arm.c (elf32_arm_add_relocation): Deleted.
(elf32_arm_write_section): Move additional relocation to emit_relocs.
(elf32_arm_count_output_relocs): New function.
(emit_relocs): New function.
(elf32_arm_emit_relocs): New function.
(elf32_arm_vxworks_emit_relocs): New function.
(elf_backend_emit_relocs): Updated to use the new functions.
(elf_backend_count_output_relocs): New define.
* bfd/elflink.c (bfd_elf_final_link): Do not add additional_reloc_count
to the relocation count.
(_bfd_elf_link_size_reloc_section): Use callback to count the
relocations which will be in output.
(_bfd_elf_default_count_output_relocs): New function.
* bfd/elfxx-target.h (elf_backend_count_output_relocs): New define.
---
bfd/elf-bfd.h | 8 ++
bfd/elf32-arm.c | 266 ++++++++++++++++++++++++++++++++++++++++++++---------
bfd/elflink.c | 46 ++++++---
bfd/elfxx-target.h | 4 +
4 files changed, 263 insertions(+), 61 deletions(-)
diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h
index 163ef35..2f2b42c 100644
--- a/bfd/elf-bfd.h
+++ b/bfd/elf-bfd.h
@@ -1176,6 +1176,11 @@ struct elf_backend_data
unsigned int (*elf_backend_count_additional_relocs)
(asection *);
+ /* Count relocations to be output. The result may be different if the
+ input relocations are expected to be modified by the backend. */
+ unsigned int (* elf_backend_count_output_relocs)
+ (struct bfd_link_info *info, asection *o, bfd_boolean rela);
+
/* Say whether to sort relocs output by ld -r and ld --emit-relocs,
by r_offset. If NULL, default to true. */
bfd_boolean (*sort_relocs_p)
@@ -2143,6 +2148,9 @@ extern bfd_boolean _bfd_elf_link_output_relocs
(bfd *, asection *, Elf_Internal_Shdr *, Elf_Internal_Rela *,
struct elf_link_hash_entry **);
+extern unsigned int _bfd_elf_default_count_output_relocs
+ (struct bfd_link_info *info ATTRIBUTE_UNUSED, asection *o, bfd_boolean rela);
+
extern bfd_boolean _bfd_elf_adjust_dynamic_copy
(struct bfd_link_info *, struct elf_link_hash_entry *, asection *);
diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
index 3d4a458..b580f17 100644
--- a/bfd/elf32-arm.c
+++ b/bfd/elf32-arm.c
@@ -17365,39 +17365,6 @@ stm32l4xx_create_replacing_stub (struct elf32_arm_link_hash_table * htab,
/* End of stm32l4xx work-around. */
-static void
-elf32_arm_add_relocation (bfd *output_bfd, struct bfd_link_info *info,
- asection *output_sec, Elf_Internal_Rela *rel)
-{
- BFD_ASSERT (output_sec && rel);
- struct bfd_elf_section_reloc_data *output_reldata;
- struct elf32_arm_link_hash_table *htab;
- struct bfd_elf_section_data *oesd = elf_section_data (output_sec);
- Elf_Internal_Shdr *rel_hdr;
-
-
- if (oesd->rel.hdr)
- {
- rel_hdr = oesd->rel.hdr;
- output_reldata = &(oesd->rel);
- }
- else if (oesd->rela.hdr)
- {
- rel_hdr = oesd->rela.hdr;
- output_reldata = &(oesd->rela);
- }
- else
- {
- abort ();
- }
-
- bfd_byte *erel = rel_hdr->contents;
- erel += output_reldata->count * rel_hdr->sh_entsize;
- htab = elf32_arm_hash_table (info);
- SWAP_RELOC_OUT (htab) (output_bfd, rel, erel);
- output_reldata->count++;
-}
-
/* Do code byteswapping. Return FALSE afterwards so that the section is
written out as normal. */
@@ -17649,18 +17616,6 @@ elf32_arm_write_section (bfd *output_bfd,
adjust offset by hand. */
prel31_offset = text_sec->output_offset
+ text_sec->size;
-
- /* New relocation entity. */
- asection *text_out = text_sec->output_section;
- Elf_Internal_Rela rel;
- rel.r_addend = 0;
- rel.r_offset = exidx_offset;
- rel.r_info = ELF32_R_INFO (text_out->target_index,
- R_ARM_PREL31);
-
- elf32_arm_add_relocation (output_bfd, link_info,
- sec->output_section,
- &rel);
}
/* First address we can't unwind. */
@@ -18175,6 +18130,78 @@ elf32_arm_count_additional_relocs (asection *sec)
return arm_data->additional_reloc_count;
}
+static unsigned int
+elf32_arm_count_output_relocs (struct bfd_link_info *info, asection *o,
+ bfd_boolean rela)
+{
+ struct bfd_elf_section_data *esdo;
+ struct bfd_link_order *p;
+ bfd_size_type count;
+
+ esdo = elf_section_data (o->output_section);
+ if (esdo->this_hdr.sh_type != SHT_ARM_EXIDX)
+ return _bfd_elf_default_count_output_relocs (info, o, rela);
+
+ count = 0;
+ for (p = o->map_head.link_order; p != NULL; p = p->next)
+ {
+ struct _arm_elf_section_data *arm_data;
+ struct bfd_elf_section_data *esd;
+ arm_unwind_table_edit *edit_list;
+ Elf_Internal_Rela *relocs;
+ asection *sec;
+ bfd_size_type num_rel;
+ bfd_size_type num_rela;
+ unsigned int i;
+
+ if (p->type == bfd_section_reloc_link_order
+ || p->type == bfd_symbol_reloc_link_order)
+ {
+ count++;
+ continue;
+ }
+
+ sec = p->u.indirect.section;
+ arm_data = get_arm_elf_section_data (sec);
+ esd = &arm_data->elf;
+
+ if (arm_data->additional_reloc_count)
+ count += arm_data->additional_reloc_count;
+
+ edit_list = arm_data->u.exidx.unwind_edit_list;
+ if (!edit_list)
+ {
+ count += sec->reloc_count;
+ continue;
+ }
+
+ relocs = _bfd_elf_link_read_relocs (sec->owner, sec, NULL, NULL,
+ info->keep_memory);
+ num_rel = esd->rel.hdr ? NUM_SHDR_ENTRIES (esd->rel.hdr) : 0;
+ num_rela = esd->rela.hdr ? NUM_SHDR_ENTRIES (esd->rela.hdr) : 0;
+ if (rela)
+ relocs += num_rel;
+
+ for (i = 0; i < (rela ? num_rela : num_rel); i++)
+ {
+ arm_unwind_table_edit *edit_node;
+ unsigned int index;
+
+ index = (relocs[i].r_offset - sec->vma) / 8;
+
+ for (edit_node = edit_list;
+ edit_node->next && edit_node->next->index > index;
+ edit_node++);
+
+ if (edit_node->type != DELETE_EXIDX_ENTRY ||
+ edit_node->index != index)
+ count++;
+ }
+ }
+
+ return count;
+}
+
/* Called to set the sh_flags, sh_link and sh_info fields of OSECTION which
has a type >= SHT_LOOS. Returns TRUE if these fields were initialised
FALSE otherwise. ISECTION is the best guess matching section from the
@@ -18303,6 +18330,139 @@ elf32_arm_backend_symbol_processing (bfd *abfd, asymbol *sym)
sym->flags |= BSF_KEEP;
}
+static bfd_boolean
+emit_relocs (bfd *output_bfd,
+ asection *input_section,
+ Elf_Internal_Shdr *input_rel_hdr,
+ Elf_Internal_Rela *internal_relocs,
+ struct elf_link_hash_entry **rel_hash,
+ bfd_boolean (*fallback) (bfd *, asection *,
+ Elf_Internal_Shdr *,
+ Elf_Internal_Rela *,
+ struct elf_link_hash_entry **))
+{
+ _arm_elf_section_data *arm_data;
+ struct bfd_elf_section_reloc_data *output_reldata;
+ Elf_Internal_Shdr *output_rel_hdr;
+ Elf_Internal_Rela *irela;
+ Elf_Internal_Rela *irelaend;
+ asection *output_section;
+ const struct elf_backend_data *bed;
+ void (*swap_out) (bfd *, const Elf_Internal_Rela *, bfd_byte *);
+ struct bfd_elf_section_data *esdo;
+ arm_unwind_table_edit *edit_list, *edit_tail;
+ bfd_byte *erel;
+ bfd_vma offset;
+
+ arm_data = get_arm_elf_section_data (input_section);
+
+ if (!arm_data || arm_data->elf.this_hdr.sh_type != SHT_ARM_EXIDX)
+ goto fallback_label;
+
+ edit_list = arm_data->u.exidx.unwind_edit_list;
+ edit_tail = arm_data->u.exidx.unwind_edit_tail;
+
+ if (!edit_list)
+ goto fallback_label;
+
+ output_section = input_section->output_section;
+ offset = output_section->vma + input_section->output_offset;
+
+ bed = get_elf_backend_data (output_bfd);
+ esdo = elf_section_data (output_section);
+ if (esdo->rel.hdr && esdo->rel.hdr->sh_entsize == input_rel_hdr->sh_entsize)
+ {
+ output_reldata = &esdo->rel;
+ swap_out = bed->s->swap_reloc_out;
+ }
+ else if (esdo->rela.hdr &&
+ esdo->rela.hdr->sh_entsize == input_rel_hdr->sh_entsize)
+ {
+ output_reldata = &esdo->rela;
+ swap_out = bed->s->swap_reloca_out;
+ }
+ else
+ {
+ (*_bfd_error_handler)
+ (_("%B: relocation size mismatch in %B section %A"),
+ output_bfd, input_section->owner, input_section);
+ bfd_set_error (bfd_error_wrong_format);
+ return FALSE;
+ }
+
+ output_rel_hdr = output_reldata->hdr;
+ erel = output_rel_hdr->contents;
+ erel += output_reldata->count * input_rel_hdr->sh_entsize;
+
+ irela = internal_relocs;
+ irelaend = irela + (NUM_SHDR_ENTRIES (input_rel_hdr)
+ * bed->s->int_rels_per_ext_rel);
+ while (irela < irelaend)
+ {
+ arm_unwind_table_edit *edit_node, *edit_next;
+ Elf_Internal_Rela rel;
+ bfd_vma bias;
+ bfd_vma index;
+
+ index = (irela->r_offset - offset) / 8;
+
+ bias = 0;
+ edit_node = edit_list;
+ for (edit_next = edit_list;
+ edit_next && edit_next->index <= index;
+ edit_next = edit_node->next)
+ {
+ bias++;
+ edit_node = edit_next;
+ }
+
+ if (edit_node->type != DELETE_EXIDX_ENTRY || edit_node->index != index)
+ {
+ rel.r_offset = irela->r_offset - bias * 8;
+ rel.r_info = irela->r_info;
+ rel.r_addend = irela->r_addend;
+
+ (*swap_out) (output_bfd, &rel, erel);
+ erel += output_rel_hdr->sh_entsize;
+ output_reldata->count++;
+ }
+
+ irela += bed->s->int_rels_per_ext_rel;
+ }
+
+ if (edit_tail->type == INSERT_EXIDX_CANTUNWIND_AT_END)
+ {
+ /* New relocation entity. */
+ asection *text_sec = edit_tail->linked_section;
+ asection *text_out = text_sec->output_section;
+ bfd_vma exidx_offset = offset + input_section->size - 8;
+ Elf_Internal_Rela rel;
+
+ rel.r_addend = 0;
+ rel.r_offset = exidx_offset;
+ rel.r_info = ELF32_R_INFO (text_out->target_index, R_ARM_PREL31);
+ (*swap_out) (output_bfd, &rel, erel);
+ output_reldata->count++;
+ }
+
+ return TRUE;
+
+fallback_label:
+ return fallback (output_bfd, input_section, input_rel_hdr,
+ internal_relocs, rel_hash);
+}
+
+static bfd_boolean
+elf32_arm_emit_relocs (bfd *output_bfd,
+ asection *input_section,
+ Elf_Internal_Shdr *input_rel_hdr,
+ Elf_Internal_Rela *internal_relocs,
+ struct elf_link_hash_entry **rel_hash)
+{
+ return emit_relocs (output_bfd, input_section, input_rel_hdr, internal_relocs,
+ rel_hash, _bfd_elf_link_output_relocs);
+}
+
#undef elf_backend_copy_special_section_fields
#define elf_backend_copy_special_section_fields elf32_arm_copy_special_section_fields
@@ -18333,6 +18493,7 @@ elf32_arm_backend_symbol_processing (bfd *abfd, asymbol *sym)
#define bfd_elf32_bfd_final_link elf32_arm_final_link
#define bfd_elf32_get_synthetic_symtab elf32_arm_get_synthetic_symtab
+#define elf_backend_emit_relocs elf32_arm_emit_relocs
#define elf_backend_get_symbol_type elf32_arm_get_symbol_type
#define elf_backend_gc_mark_hook elf32_arm_gc_mark_hook
#define elf_backend_gc_mark_extra_sections elf32_arm_gc_mark_extra_sections
@@ -18361,6 +18522,7 @@ elf32_arm_backend_symbol_processing (bfd *abfd, asymbol *sym)
#define elf_backend_begin_write_processing elf32_arm_begin_write_processing
#define elf_backend_add_symbol_hook elf32_arm_add_symbol_hook
#define elf_backend_count_additional_relocs elf32_arm_count_additional_relocs
+#define elf_backend_count_output_relocs elf32_arm_count_output_relocs
#define elf_backend_symbol_processing elf32_arm_backend_symbol_processing
#define elf_backend_can_refcount 1
@@ -18527,6 +18689,17 @@ elf32_arm_vxworks_final_write_processing (bfd *abfd, bfd_boolean linker)
elf_vxworks_final_write_processing (abfd, linker);
}
+static bfd_boolean
+elf32_arm_vxworks_emit_relocs (bfd *output_bfd,
+ asection *input_section,
+ Elf_Internal_Shdr *input_rel_hdr,
+ Elf_Internal_Rela *internal_relocs,
+ struct elf_link_hash_entry **rel_hash)
+{
+ return emit_relocs (output_bfd, input_section, input_rel_hdr, internal_relocs,
+ rel_hash, elf_vxworks_emit_relocs);
+}
+
#undef elf32_bed
#define elf32_bed elf32_arm_vxworks_bed
@@ -18535,7 +18708,7 @@ elf32_arm_vxworks_final_write_processing (bfd *abfd, bfd_boolean linker)
#undef elf_backend_final_write_processing
#define elf_backend_final_write_processing elf32_arm_vxworks_final_write_processing
#undef elf_backend_emit_relocs
-#define elf_backend_emit_relocs elf_vxworks_emit_relocs
+#define elf_backend_emit_relocs elf32_arm_vxworks_emit_relocs
#undef elf_backend_may_use_rel_p
#define elf_backend_may_use_rel_p 0
@@ -18899,6 +19072,7 @@ elf32_arm_symbian_plt_sym_val (bfd_vma i, const asection *plt,
(SEC_HAS_CONTENTS | SEC_IN_MEMORY | SEC_LINKER_CREATED)
#undef elf_backend_emit_relocs
+#define elf_backend_emit_relocs elf32_arm_emit_relocs
#undef bfd_elf32_bfd_link_hash_table_create
#define bfd_elf32_bfd_link_hash_table_create elf32_arm_symbian_link_hash_table_create
diff --git a/bfd/elflink.c b/bfd/elflink.c
index 3e24940..20e7086 100644
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -2447,13 +2447,23 @@ _bfd_elf_link_read_relocs (bfd *abfd,
section header for a section containing relocations for O. */
static bfd_boolean
-_bfd_elf_link_size_reloc_section (bfd *abfd,
- struct bfd_elf_section_reloc_data *reldata)
+_bfd_elf_link_size_reloc_section (bfd *abfd, struct bfd_link_info *info,
+ asection *o, bfd_boolean rela)
{
- Elf_Internal_Shdr *rel_hdr = reldata->hdr;
+ struct bfd_elf_section_data *esdo;
+ const struct elf_backend_data *bed;
+ struct bfd_elf_section_reloc_data *reldata;
+ Elf_Internal_Shdr *rel_hdr;
+ unsigned int count;
+
+ esdo = elf_section_data (o);
+ reldata = rela ? &esdo->rela : &esdo->rel;
+ rel_hdr = reldata->hdr;
/* That allows us to calculate the size of the section. */
- rel_hdr->sh_size = rel_hdr->sh_entsize * reldata->count;
+ bed = get_elf_backend_data (abfd);
+ count = (*bed->elf_backend_count_output_relocs) (info, o, rela);
+ rel_hdr->sh_size = count * rel_hdr->sh_entsize;
/* The contents field must last into write_object_contents, so we
allocate it with bfd_alloc rather than malloc. Also since we
@@ -2541,6 +2551,19 @@ _bfd_elf_link_output_relocs (bfd *output_bfd,
return TRUE;
}
+
+unsigned int
+_bfd_elf_default_count_output_relocs (
+ struct bfd_link_info *info ATTRIBUTE_UNUSED, asection *o, bfd_boolean rela)
+{
+ struct bfd_elf_section_data *esdo;
+ struct bfd_elf_section_reloc_data *reldata;
+
+ esdo = elf_section_data (o);
+ reldata = rela ? &esdo->rela : &esdo->rel;
+
+ return reldata->count;
+}
\f
/* Make weak undefined symbols in PIE dynamic. */
@@ -11182,12 +11205,12 @@ bfd_elf_final_link (bfd *abfd, struct bfd_link_info *info)
for (o = abfd->sections; o != NULL; o = o->next)
{
struct bfd_elf_section_data *esdo = elf_section_data (o);
+ unsigned int additional_reloc_count = 0;
o->reloc_count = 0;
for (p = o->map_head.link_order; p != NULL; p = p->next)
{
unsigned int reloc_count = 0;
- unsigned int additional_reloc_count = 0;
struct bfd_elf_section_data *esdi = NULL;
if (p->type == bfd_section_reloc_link_order
@@ -11273,21 +11296,14 @@ bfd_elf_final_link (bfd *abfd, struct bfd_link_info *info)
if (reloc_count == 0)
continue;
- reloc_count += additional_reloc_count;
o->reloc_count += reloc_count;
if (p->type == bfd_indirect_link_order && emit_relocs)
{
if (esdi->rel.hdr)
- {
esdo->rel.count += NUM_SHDR_ENTRIES (esdi->rel.hdr);
- esdo->rel.count += additional_reloc_count;
- }
if (esdi->rela.hdr)
- {
esdo->rela.count += NUM_SHDR_ENTRIES (esdi->rela.hdr);
- esdo->rela.count += additional_reloc_count;
- }
}
else
{
@@ -11298,7 +11314,7 @@ bfd_elf_final_link (bfd *abfd, struct bfd_link_info *info)
}
}
- if (o->reloc_count > 0)
+ if (o->reloc_count > 0 || additional_reloc_count > 0)
o->flags |= SEC_RELOC;
else
{
@@ -11336,11 +11352,11 @@ bfd_elf_final_link (bfd *abfd, struct bfd_link_info *info)
if ((o->flags & SEC_RELOC) != 0)
{
if (esdo->rel.hdr
- && !(_bfd_elf_link_size_reloc_section (abfd, &esdo->rel)))
+ && !(_bfd_elf_link_size_reloc_section (abfd, info, o, FALSE)))
goto error_return;
if (esdo->rela.hdr
- && !(_bfd_elf_link_size_reloc_section (abfd, &esdo->rela)))
+ && !(_bfd_elf_link_size_reloc_section (abfd, info, o, TRUE)))
goto error_return;
}
diff --git a/bfd/elfxx-target.h b/bfd/elfxx-target.h
index 97aa5e6..5424cf3 100644
--- a/bfd/elfxx-target.h
+++ b/bfd/elfxx-target.h
@@ -551,6 +551,9 @@
#ifndef elf_backend_count_additional_relocs
#define elf_backend_count_additional_relocs NULL
#endif
+#ifndef elf_backend_count_output_relocs
+#define elf_backend_count_output_relocs _bfd_elf_default_count_output_relocs
+#endif
#ifndef elf_backend_sort_relocs_p
#define elf_backend_sort_relocs_p NULL
#endif
@@ -773,6 +776,7 @@ static struct elf_backend_data elfNN_bed =
elf_backend_emit_relocs,
elf_backend_count_relocs,
elf_backend_count_additional_relocs,
+ elf_backend_count_output_relocs,
elf_backend_sort_relocs_p,
elf_backend_grok_prstatus,
elf_backend_grok_psinfo,
--
2.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4] ARM: Fix relocation of EXIDX sections
2016-09-23 10:25 ` [PATCH v4] ARM: Fix relocation of EXIDX sections Akihiko Odaki
@ 2016-09-23 15:35 ` Nick Clifton
2016-09-26 9:40 ` Szabolcs Nagy
1 sibling, 0 replies; 7+ messages in thread
From: Nick Clifton @ 2016-09-23 15:35 UTC (permalink / raw)
To: Akihiko Odaki, binutils; +Cc: Andreas Schwab, Paul Brook, Yury Usishchev
Hi Akihiko-san,
Thank you very much for persisting with this patch. This time there were
no problems or regressions. :-)
> bfd * elf-bfd.h: Add callback to count relocations in the final output.
> * elf-arm.c (elf32_arm_add_relocation): Deleted.
> (elf32_arm_write_section): Move additional relocation to emit_relocs.
> (elf32_arm_count_output_relocs): New function.
> (emit_relocs): New function.
> (elf32_arm_emit_relocs): New function.
> (elf32_arm_vxworks_emit_relocs): New function.
> (elf_backend_emit_relocs): Updated to use the new functions.
> (elf_backend_count_output_relocs): New define.
> * bfd/elflink.c (bfd_elf_final_link): Do not add additional_reloc_count
> to the relocation count.
> (_bfd_elf_link_size_reloc_section): Use callback to count the
> relocations which will be in output.
> (_bfd_elf_default_count_output_relocs): New function.
> * bfd/elfxx-target.h (elf_backend_count_output_relocs): New define.
Approved and applied.
Cheers
Nick
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4] ARM: Fix relocation of EXIDX sections
2016-09-23 10:25 ` [PATCH v4] ARM: Fix relocation of EXIDX sections Akihiko Odaki
2016-09-23 15:35 ` Nick Clifton
@ 2016-09-26 9:40 ` Szabolcs Nagy
2016-09-26 16:46 ` Szabolcs Nagy
1 sibling, 1 reply; 7+ messages in thread
From: Szabolcs Nagy @ 2016-09-26 9:40 UTC (permalink / raw)
To: Akihiko Odaki, binutils
Cc: nd, Nick Clifton, Andreas Schwab, Paul Brook, Yury Usishchev
On 23/09/16 11:24, Akihiko Odaki wrote:
> As reported in PR binutils/20595, BFD has a bug that it doesn't delete
> relocations for deleted exidx. This change fixes the behavior.
>
> bfd * elf-bfd.h: Add callback to count relocations in the final output.
> * elf-arm.c (elf32_arm_add_relocation): Deleted.
> (elf32_arm_write_section): Move additional relocation to emit_relocs.
> (elf32_arm_count_output_relocs): New function.
> (emit_relocs): New function.
> (elf32_arm_emit_relocs): New function.
> (elf32_arm_vxworks_emit_relocs): New function.
> (elf_backend_emit_relocs): Updated to use the new functions.
> (elf_backend_count_output_relocs): New define.
> * bfd/elflink.c (bfd_elf_final_link): Do not add additional_reloc_count
> to the relocation count.
> (_bfd_elf_link_size_reloc_section): Use callback to count the
> relocations which will be in output.
> (_bfd_elf_default_count_output_relocs): New function.
> * bfd/elfxx-target.h (elf_backend_count_output_relocs): New define.
> ---
> bfd/elf-bfd.h | 8 ++
> bfd/elf32-arm.c | 266 ++++++++++++++++++++++++++++++++++++++++++++---------
> bfd/elflink.c | 46 ++++++---
> bfd/elfxx-target.h | 4 +
> 4 files changed, 263 insertions(+), 61 deletions(-)
>
this breaks cross compilation of glibc on arm.
i'm still investigating the issue, when linking libc_pic.so i get
Program received signal SIGSEGV, Segmentation fault.
elf_link_adjust_relocs (abfd=abfd@entry=0x7a2f30, reldata=reldata@entry=0x35f52f8, sort=sort@entry=1) at
/SRC/bfd/elflink.c:8406
8406 BFD_ASSERT ((*rel_hash)->indx >= 0);
(gdb) bt
#0 elf_link_adjust_relocs (abfd=abfd@entry=0x7a2f30, reldata=reldata@entry=0x35f52f8, sort=sort@entry=1) at
/SRC/bfd/elflink.c:8406
#1 0x000000000047f06d in bfd_elf_final_link (abfd=abfd@entry=0x7a2f30, info=info@entry=0x78ddc0 <link_info>)
at /SRC/bfd/elflink.c:11966
#2 0x000000000045590b in elf32_arm_final_link (abfd=0x7a2f30, info=0x78ddc0 <link_info>) at
/SRC/bfd/elf32-arm.c:12841
#3 0x00000000004181e4 in ldwrite () at /SRC/ld/ldwrite.c:577
#4 0x0000000000403755 in main (argc=<optimised out>, argv=<optimised out>) at /SRC/ld/ldmain.c:431
(gdb) i loc
irela = {{r_offset = 0, r_info = 3153664, r_addend = 0}, {r_offset = 13, r_info = 8007472, r_addend = 4408895},
{r_offset = 13, r_info = 7339, r_addend = 85397}}
j = <optimised out>
i = <optimised out>
bed = 0x788060 <elf32_bed>
erela = 0x385ba00 "\b"
swap_in = 0x45a8f0 <bfd_elf32_swap_reloc_in>
swap_out = 0x45a980 <bfd_elf32_swap_reloc_out>
r_type_mask = 255
r_sym_shift = 8
count = 3
rel_hash = 0x3763330
__PRETTY_FUNCTION__ = "elf_link_adjust_relocs"
(gdb) p *rel_hash
$1 = (struct elf_link_hash_entry *) 0x20
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4] ARM: Fix relocation of EXIDX sections
2016-09-26 9:40 ` Szabolcs Nagy
@ 2016-09-26 16:46 ` Szabolcs Nagy
0 siblings, 0 replies; 7+ messages in thread
From: Szabolcs Nagy @ 2016-09-26 16:46 UTC (permalink / raw)
To: Akihiko Odaki, binutils
Cc: nd, Nick Clifton, Andreas Schwab, Paul Brook, Yury Usishchev
On 26/09/16 10:39, Szabolcs Nagy wrote:
>
> this breaks cross compilation of glibc on arm.
>
i attached a test case to
https://sourceware.org/bugzilla/show_bug.cgi?id=20636
it seems the relocation count for ".ARM.exidx.text.unlikely"
section is wrong causing uninitialized hash entry access.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-09-26 16:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-22 1:52 [PATCH] ARM: Fix elf32_arm_count_additional_relocs Akihiko Odaki
2016-09-22 8:36 ` Renlin Li
2016-09-23 4:40 ` [PATCH v2] " Akihiko Odaki
2016-09-23 10:25 ` [PATCH v4] ARM: Fix relocation of EXIDX sections Akihiko Odaki
2016-09-23 15:35 ` Nick Clifton
2016-09-26 9:40 ` Szabolcs Nagy
2016-09-26 16:46 ` Szabolcs Nagy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).