From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Cc: Nick Clifton <nickc@redhat.com>
Subject: .rela.dyn comment fix and add missing ChangeLog entry
Date: Mon, 09 Jan 2017 01:45:00 -0000 [thread overview]
Message-ID: <20170109014453.GV31129@bubble.grove.modra.org> (raw)
ChangeLog entry missed from commit dd90581873.
* readelf.c (process_section_headers): Correct .rel.dyn/.rela.dyn
comment.
diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index e5f2e0f..b5e82fe 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,8 @@
+2017-01-09 Alan Modra <amodra@gmail.com>
+
+ * readelf.c (process_section_headers): Correct .rel.dyn/.rela.dyn
+ comment.
+
2017-01-06 Nick Clifton <nickc@redhat.com>
* MAINTAINERS: Move Paul Brook to the Past Maintainers section.
diff --git a/binutils/ChangeLog-2016 b/binutils/ChangeLog-2016
index 423a902..49cdc50 100644
--- a/binutils/ChangeLog-2016
+++ b/binutils/ChangeLog-2016
@@ -330,6 +330,9 @@
2016-08-19 Nick Clifton <nickc@redhat.com>
+ * readelf.c (process_section_headers): Sanity check section headers.
+ (process_symbol_table): Don't warn on solaris binaries with local
+ symbols past symtab sh_info.
* testsuite/binutils-all/readelf.s: Adjust expected ordering of
sections.
* testsuite/binutils-all/readelf.s-64: Likewise.
diff --git a/binutils/readelf.c b/binutils/readelf.c
index 1eaa505..b488714 100644
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -6092,8 +6092,8 @@ process_section_headers (FILE * file)
&& (streq (SECTION_NAME (section), ".rel.dyn")
|| streq (SECTION_NAME (section), ".rela.dyn")))
/* The .rel.dyn and .rela.dyn sections have an sh_info field
- of zero. No idea why. I would have expected the index
- of the .plt section. */
+ of zero. The relocations in these sections may apply
+ to many different sections. */
;
else
warn (_("[%2u]: Info field (%u) should index a relocatable section.\n"),
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2017-01-09 1:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109014453.GV31129@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).