From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103667 invoked by alias); 17 Jan 2017 20:08:16 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 103511 invoked by uid 89); 17 Jan 2017 20:08:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.3 required=5.0 tests=AWL,BAYES_05,RCVD_IN_JMF_BL autolearn=no version=3.3.2 spammy=H*r:sk:server2, H*RU:sk:server2, Hx-spam-relays-external:sk:server2, HX-HELO:sk:server2 X-HELO: server28.host.bg Received: from server28.host.bg (HELO server28.host.bg) (87.120.40.98) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jan 2017 20:08:05 +0000 Received: from [95.87.234.74] (port=54048 helo=localhost.localdomain) by server28.host.bg with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1cTa2z-000ET6-6i; Tue, 17 Jan 2017 22:08:01 +0200 From: Dimitar Dimitrov To: binutils@sourceware.org Cc: Dimitar Dimitrov Subject: [PATCH] ld: testsuite: Filter unique.exp cases for shared lib capability Date: Tue, 17 Jan 2017 20:08:00 -0000 Message-Id: <20170117200741.15254-1-dimitar@dinux.eu> X-Get-Message-Sender-Via: server28.host.bg: authenticated_id: dimitar@dinux.eu X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00276.txt.bz2 This patch fixes testsuite failures on PRU (an embedded target). I did not notice any new testsuite regressions on x86_64. ld/ 2017-01-17 Dimitar Dimitrov * testsuite/ld-unique/unique.exp: Filter shared lib cases in uniqeue.exp, as not all targets have such support. Signed-off-by: Dimitar Dimitrov --- ld/testsuite/ld-unique/unique.exp | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/ld/testsuite/ld-unique/unique.exp b/ld/testsuite/ld-unique/unique.exp index 668ac95377..15566d4214 100644 --- a/ld/testsuite/ld-unique/unique.exp +++ b/ld/testsuite/ld-unique/unique.exp @@ -109,7 +109,7 @@ if ![ld_compile "$CC -c" "$srcdir/$subdir/unique_empty.s" "tmpdir/unique_empty.o } # Create pic object file containing unique symbol. -if ![ld_compile "$CC -c -fPIC" "$srcdir/$subdir/unique_shared.s" "tmpdir/unique_shared.o"] { +if { [check_shared_lib_support] && ![ld_compile "$CC -c -fPIC" "$srcdir/$subdir/unique_shared.s" "tmpdir/unique_shared.o"] } { fail "Could not create a pic unique object" set fails [expr $fails + 1] } @@ -121,19 +121,19 @@ if ![ld_link $CC "tmpdir/unique_prog" "tmpdir/unique.o"] { } # Create shared library containing unique symbol. -if ![ld_link $ld "tmpdir/libunique_shared.so" "-shared tmpdir/unique_shared.o"] { +if { [check_shared_lib_support] && ![ld_link $ld "tmpdir/libunique_shared.so" "-shared tmpdir/unique_shared.o"] } { fail "Could not create a shared library containing an unique symbol" set fails [expr $fails + 1] } # Create executable NOT containing unique symbol linked against library. -if ![ld_link $CC "tmpdir/unique_shared_prog" "-Ltmpdir tmpdir/unique_empty.o -Wl,-Bdynamic,-rpath=./tmpdir -lunique_shared"] { +if { [check_shared_lib_support] && ![ld_link $CC "tmpdir/unique_shared_prog" "-Ltmpdir tmpdir/unique_empty.o -Wl,-Bdynamic,-rpath=./tmpdir -lunique_shared"] } { fail "Could not link a dynamic executable" set fails [expr $fails + 1] } # Create shared library containing unique symbol with reference. -if ![ld_link $ld "tmpdir/libunique_shared_ref.so" "-shared tmpdir/unique_shared.o tmpdir/unique_empty.o"] { +if { [check_shared_lib_support] && ![ld_link $ld "tmpdir/libunique_shared_ref.so" "-shared tmpdir/unique_shared.o tmpdir/unique_empty.o"] } { fail "Could not create a shared library containing an unique symbol with reference" set fails [expr $fails + 1] } @@ -191,6 +191,11 @@ if { $fails == 0 } { pass "Checking empty unique object" } +# Only shared library tests below. +if { ![check_shared_lib_support] } { + return +} + # Check the unique PIC file. if {! [check_osabi tmpdir/unique_shared.o {UNIX - GNU}]} { fail "PIC Object containing unique does not have an OS/ABI field of GNU" -- 2.11.0