From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: [GOLD] PowerPC64 TOC indirect to TOC relative segfault
Date: Fri, 03 Feb 2017 09:35:00 -0000 [thread overview]
Message-ID: <20170203093501.GG3731@bubble.grove.modra.org> (raw)
Newer versions of gcc don't create an empty .toc section.
* powerpc.cc (Powerpc_relobj::make_toc_relative): Don't crash
when no .toc section exists.
diff --git a/gold/powerpc.cc b/gold/powerpc.cc
index a67c336..4abfcec 100644
--- a/gold/powerpc.cc
+++ b/gold/powerpc.cc
@@ -1986,6 +1986,12 @@ Powerpc_relobj<size, big_endian>::make_toc_relative(
if (size != 64)
return false;
+ // With -mcmodel=medium code it is quite possible to have
+ // toc-relative relocs referring to objects outside the TOC.
+ // Don't try to look at a non-existent TOC.
+ if (this->toc_shndx() == 0)
+ return false;
+
// Convert VALUE back to an address by adding got_base (see below),
// then to an offset in the TOC by subtracting the TOC output
// section address and the TOC output offset. Since this TOC output
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2017-02-03 9:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203093501.GG3731@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).