From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119842 invoked by alias); 15 Feb 2017 03:43:52 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 119794 invoked by uid 89); 15 Feb 2017 03:43:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1093, approve, meeting X-HELO: mail-pf0-f196.google.com Received: from mail-pf0-f196.google.com (HELO mail-pf0-f196.google.com) (209.85.192.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Feb 2017 03:43:46 +0000 Received: by mail-pf0-f196.google.com with SMTP id 68so5727034pfx.2 for ; Tue, 14 Feb 2017 19:43:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=C7jeqnlsTFfhaCasANpXhSlDl42nQRaTlHAYSMwwSuU=; b=VNluc5DV2PjqjD7pfGrOrx2yGYg+G+h2CfyKQr01OcmJtIvdkGF+HW0rllcmySTmNp jl9n1e8BneURSYb9friHxtTmq6dlfEFrD2ASJQpMEWl4Lq4RC4N+artIbCij6CnKTURE ESuLkoPCQYSGTaLoMRJrXv+XhAh5NYGDpZhlLB7ewVca8UjPgLFukqieEUf8vQjTWtJd bjXgU1UYkXm+X5TVAo3k9xjdUX4RzzO7wyO4zthQXub2PWiV0EkUnogF7zOtij1metTn AYMRkk1HAUFoNsNXpXOE43czJk0XfM9cZUxRUSHwAAfNiupEUhsKv5FLt0vwo7NxuiKa zXQg== X-Gm-Message-State: AMke39m7pXpFDnkVMOcZ4H1Up9nh3Go+xFmmDMywuDGfhXK5RYQ4/8PZ5WLsHqzItYl18A== X-Received: by 10.98.147.207 with SMTP id r76mr35231459pfk.111.1487130225646; Tue, 14 Feb 2017 19:43:45 -0800 (PST) Received: from bubble.grove.modra.org (CPE-58-160-71-80.tyqh2.lon.bigpond.net.au. [58.160.71.80]) by smtp.gmail.com with ESMTPSA id i21sm3726718pfi.94.2017.02.14.19.43.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Feb 2017 19:43:44 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id A29EEC323E; Wed, 15 Feb 2017 14:13:40 +1030 (ACDT) Date: Wed, 15 Feb 2017 03:43:00 -0000 From: Alan Modra To: "Maciej W. Rozycki" Cc: Nick Clifton , James Cowgill , binutils@sourceware.org Subject: Re: [PATCH] PR ld/20828: Move symbol version processing ahead of GC symbol sweep Message-ID: <20170215034340.GE3731@bubble.grove.modra.org> References: <20170202032433.GD3731@bubble.grove.modra.org> <20170215015451.GC3731@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170215015451.GC3731@bubble.grove.modra.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00109.txt.bz2 On Wed, Feb 15, 2017 at 12:24:51PM +1030, Alan Modra wrote: > On Thu, Feb 09, 2017 at 07:48:50PM +0000, Maciej W. Rozycki wrote: > > 1. Executable is being linked. > > > > 2. Symbol has been defined locally. > > > > 3. Symbol is being dynamically exported. > > > > 4. Symbol will be garbage-collected. > > > > however #4 cannot happen together with #1-#3 at once, because meeting > > #1-#3 means the symbol cannot be garbage-collected. IOW, if we get to > > here, then either `->dynindx == -1' and we don't care or `->dynindx != -1' > > and this won't change. So it looks like most of my update can be dropped > > and only the part below retained. > > > > Have I missed anything here? > > I think you are correct, and this update makes the original patch OK > to apply. I'm willing to approve it. So I went and tested the patch, and found failures on x86_64 and other architectures. FAIL: Build rdynamic-1 FAIL: vers4a FAIL: vers9 This says the patch is not OK. -- Alan Modra Australia Development Lab, IBM