From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64448 invoked by alias); 16 Feb 2017 20:13:36 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 64306 invoked by uid 89); 16 Feb 2017 20:13:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*MI:sk:e39ff45, H*i:sk:e39ff45, H*f:sk:e39ff45 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Feb 2017 20:13:34 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 905D87E9E0; Thu, 16 Feb 2017 20:13:34 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-221.ams2.redhat.com [10.36.116.221]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1GKDVpD025296 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 16 Feb 2017 15:13:33 -0500 Date: Thu, 16 Feb 2017 20:13:00 -0000 From: Jan Kratochvil To: Nick Clifton Cc: binutils@sourceware.org, Victor Leschuk Subject: Re: [PATCH 1/6] DWARF attrs: add delimiter Message-ID: <20170216201329.GA22230@host1.jankratochvil.net> References: <148719947800.19826.950569475344047705.stgit@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00163.txt.bz2 Hi Nick, On Thu, 16 Feb 2017 11:59:10 +0100, Nick Clifton wrote: > The patch looks good to me. But ... I would be happier if it included > a testcase to check the new functionality. before coding it - is it OK do use x86_64 specific .s (and output .d) files where .s is built with? -gdwarf-5 -S -dA I understand an arch-independent .s file would be better but that would need a lot of hand coding IMO. Thanks, Jan