From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59544 invoked by alias); 22 Feb 2017 13:23:04 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 59526 invoked by uid 89); 22 Feb 2017 13:23:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: bastet.se.axis.com Received: from bastet.se.axis.com (HELO bastet.se.axis.com) (195.60.68.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Feb 2017 13:23:02 +0000 Received: from localhost (localhost [127.0.0.1]) by bastet.se.axis.com (Postfix) with ESMTP id 53AE3181EB; Wed, 22 Feb 2017 14:23:00 +0100 (CET) Received: from bastet.se.axis.com ([IPv6:::ffff:127.0.0.1]) by localhost (bastet.se.axis.com [::ffff:127.0.0.1]) (amavisd-new, port 10024) with LMTP id PYAXDPgYqJzI; Wed, 22 Feb 2017 14:22:58 +0100 (CET) Received: from boulder02.se.axis.com (boulder02.se.axis.com [10.0.8.16]) by bastet.se.axis.com (Postfix) with ESMTPS id CEDEC183A0; Wed, 22 Feb 2017 14:22:57 +0100 (CET) Received: from boulder02.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 96E7D1A075; Wed, 22 Feb 2017 14:22:57 +0100 (CET) Received: from boulder02.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8BF1B1A066; Wed, 22 Feb 2017 14:22:57 +0100 (CET) Received: from thoth.se.axis.com (unknown [10.0.2.173]) by boulder02.se.axis.com (Postfix) with ESMTP; Wed, 22 Feb 2017 14:22:57 +0100 (CET) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by thoth.se.axis.com (Postfix) with ESMTP id 7F216729; Wed, 22 Feb 2017 14:22:57 +0100 (CET) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id v1MDMvMR003228; Wed, 22 Feb 2017 14:22:57 +0100 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id v1MDMuaD003224; Wed, 22 Feb 2017 14:22:56 +0100 Date: Wed, 22 Feb 2017 13:23:00 -0000 Message-Id: <201702221322.v1MDMuaD003224@ignucius.se.axis.com> From: Hans-Peter Nilsson To: JBeulich@suse.com CC: binutils@sourceware.org In-reply-to: <58AC213E020000780013C307@prv-mh.provo.novell.com> (JBeulich@suse.com) Subject: Re: [PATCH] gas: require an operand to .startof.()/.sizeof.() MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 X-SW-Source: 2017-02/txt/msg00249.txt.bz2 > Date: Tue, 21 Feb 2017 03:15:10 -0700 > From: "Jan Beulich" > gas/ > 2017-02-21 Jan Beulich > > * expr.c (operand): Handle missing operand to .startof.() and > .sizeof.(). > * testsuite/gas/all/err-sizeof.s: New. Target is cris-axis-linux-gnu Target is cris-axis-elf Host is x86_64-pc-linux-gnu but compiling with -m32 (unknown if that matters, but please consider your undoubtedly large list of targets tested for your patches). Running /tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/all/gas.exp ... FAIL: gas/all/err-sizeof.s (test for excess errors) gas.log: FAIL: gas/all/err-sizeof.s (test for excess errors) Excess errors: /tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/all//err-sizeof.s:6: Error: expression too complex Committed: gas/ * testsuite/gas/all/err-sizeof.s: Include cris*-*-* in the list of targets yielding an error message matching "too complex". diff --git a/gas/testsuite/gas/all/err-sizeof.s b/gas/testsuite/gas/all/err-sizeof.s index 4ddb5bd..457856b 100644 --- a/gas/testsuite/gas/all/err-sizeof.s +++ b/gas/testsuite/gas/all/err-sizeof.s @@ -16,6 +16,6 @@ ;# { dg-error "UND" "undefined" { target *-*-* } 5 } ;# { dg-error "junk at end" "junk" { target *-*-* } 6 } ;# { dg-error "UND" "undefined" { target *-*-* } 6 } -;# { dg-error "too complex" "too complex" { target powerpc*-*-* } 6 } +;# { dg-error "too complex" "too complex" { target powerpc*-*-* cris*-*-* } 6 } ;# { dg-warning "zero assumed" "missing" { target *-*-* } 9 } ;# { dg-warning "zero assumed" "missing" { target *-*-* } 10 } brgds, H-P