From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111599 invoked by alias); 8 Apr 2017 01:08:03 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 111578 invoked by uid 89); 8 Apr 2017 01:08:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=mall, intending, dodgy X-HELO: mail-pg0-f52.google.com Received: from mail-pg0-f52.google.com (HELO mail-pg0-f52.google.com) (74.125.83.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Apr 2017 01:08:01 +0000 Received: by mail-pg0-f52.google.com with SMTP id 21so80510397pgg.1 for ; Fri, 07 Apr 2017 18:08:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Xym1ORvKY+vJSXReV2wwPQ9IbRXcSjL6ocFHCmbMpMA=; b=k0/wQ2ZPCN2gCOE5tEEnZjMckIIvOmLK45h4CUFN+rHDTc37FJT/DHw2JM21Dpj95W 9URMjuGRHD2Ffa/57pSgGh3jy2MzACu424E43gVp703UuQkmiFl6sUNxW5HHbdscVA2R KvR/S1CFOb5TC5+/S5I15KnoYwsPxuu8ASZg+oaatvh8H6cuUuGxx8O4V8/aFxdQzYLs lR0J9cUErhqts5tccvDOfdocwrX4hmjS6euwVi5LlpyCo0SU0kwHb34gDylh2UoN5M9p C/OyyoRfdGHXVNXpRaTgU4S+cBJ7Ap5eDx34Jjr/bTA1WHwSKqjns7H/puQz7EpWxNgA MSng== X-Gm-Message-State: AN3rC/4gn+zCjFiZ5qJoHKceKB0jGXiqlzUxSZtkOv+UEIOD9E2pfVvcvebpb6b96Qv1xA== X-Received: by 10.99.0.209 with SMTP id 200mr5012895pga.210.1491613681332; Fri, 07 Apr 2017 18:08:01 -0700 (PDT) Received: from bubble.grove.modra.org (CPE-58-160-71-80.tyqh2.lon.bigpond.net.au. [58.160.71.80]) by smtp.gmail.com with ESMTPSA id t70sm11654233pgd.33.2017.04.07.18.08.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2017 18:08:00 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id B810DC7693; Sat, 8 Apr 2017 10:37:56 +0930 (ACST) Date: Sat, 08 Apr 2017 01:08:00 -0000 From: Alan Modra To: Peter Bergner Cc: binutils@sourceware.org Subject: Re: Remove E6500 insns from PPC_OPCODE_ALTIVEC2 Message-ID: <20170408010756.GY16711@bubble.grove.modra.org> References: <20170407095345.GU16711@bubble.grove.modra.org> <9d148375-51cf-65bd-7a9f-2f6ab3f5f806@vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9d148375-51cf-65bd-7a9f-2f6ab3f5f806@vnet.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00085.txt.bz2 On Fri, Apr 07, 2017 at 07:59:23AM -0500, Peter Bergner wrote: > On 4/7/17 4:53 AM, Alan Modra wrote: > > This isn't losing anything from the testsuite. All of these insns > > appear in testsuite/gas/ppc/e6500.s > > > > opcodes/ > > * ppc-opc.c (powerpc_opcodes > lvexhx, lvepx, lvexwx, stvexbx, stvexhx, stvexwx, lvtrx, lvtlx, > > lvswx, stvfrx, stvflx, stvswx, lvsm, stvepxl, lvtrxl, stvepx, > > lvtlxl, lvswxl, stvfrxl, stvflxl, stvswxl>): Enable E6500 only > > vector instructions with E6500 not PPCVEC2. > > gas/ > > * testsuite/gas/ppc/altivec2.s: Delete E6500 vector insns. > > * testsuite/gas/ppc/altivec2.d: Adjust to suit. > > Looks good to me, but I have to wonder how you noticed these, unless > you read various PPC ISA docs in your free time? ;-) Thanks for reviewing. The patch came from Aaron finding an odd opcode in traces of SPEC which objdump disassembled as stswxl, then Aaron saying he couldn't find that in ISA 3.0 or 2.07. Of course, even after this patch objdump still disassembles the opcode to stswxl since we default to power9 with PPC_OPCODE_ANY, if objdump is invoked without selected a cpu. On another subject, I'd like your opinion on removing -[mM]htm options from gas and the disassembler. I think now that it was a mistake to add them in the first place (and every other use of .sticky except for -mall and -mraw). I would have liked to remove -[mM]vsx too, but "gcc -mvsx" passes on -mvsx to gas, and has done so for quite some time. So -mvsx looks impossible to remove without breaking gcc. "gcc -mhtm" on the other hand, passes -mpower8 to gas, and it's been that way since -mhtm was added to gcc. Also, I'm intending to remove some of PPC_OPCODE_*, for instance PPC_OPCODE_ALTIVEC2 can disappear and we then use #define PPCVEC2 (PPC_OPCODE_POWER8 | PPC_OPCODE_E6500) #define PPCVEC3 PPC_OPCODE_POWER9 in opcodes/ppc-opc.c which should improve gas opcode checks vs. cpu. Dodgy gcc output would then be found at compile time rather than run time (assuming -many is removed from powerpc gcc, another little project of mine). -- Alan Modra Australia Development Lab, IBM