From: Alan Modra <amodra@gmail.com>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH, RFC] ELF/LD: Always consider STB_LOCAL symbols local
Date: Thu, 13 Apr 2017 14:09:00 -0000 [thread overview]
Message-ID: <20170413140917.GT24006@bubble.grove.modra.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1704121302570.25796@tp.orcam.me.uk>
On Thu, Apr 13, 2017 at 10:26:05AM +0100, Maciej W. Rozycki wrote:
> Do not require forced local (STB_LOCAL) symbols to have a definition in
> a regular file to be considered to resolve local to the current module,
> matching `elf_link_renumber_local_hash_table_dynsyms'. In the absence
> of a regular definition any reference to a STB_LOCAL symbol will have to
> be garbage collected along with the undefined symbol itself, or the link
> will eventually fail. Either way the symbol concerned is not going to
> be external.
>
> bfd/
> * elflink.c (_bfd_elf_symbol_refs_local_p): Always return TRUE
> if forced local.
OK. I can't remember why I put the forced_local test after the
def_regular test in the original code.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2017-04-13 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 9:26 Maciej W. Rozycki
2017-04-13 14:09 ` Alan Modra [this message]
2017-04-20 15:38 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413140917.GT24006@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=macro@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).