From: Alan Modra <amodra@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] PR ld/21382: Handle symbol defined in IR and referenced in DSO
Date: Wed, 19 Apr 2017 23:25:00 -0000 [thread overview]
Message-ID: <20170419232518.GB24006@bubble.grove.modra.org> (raw)
In-Reply-To: <CAMe9rOrhv4e5FiL6_wpGQbiy5rrvjLqQqbKCX5Qq459M09BEnA@mail.gmail.com>
On Wed, Apr 19, 2017 at 11:04:48AM -0700, H.J. Lu wrote:
> On Tue, Apr 18, 2017 at 5:48 PM, Alan Modra <amodra@gmail.com> wrote:
> > On Fri, Apr 14, 2017 at 08:44:56AM -0700, H.J. Lu wrote:
> >
> >> +++ b/bfd/elflink.c
> >> + /* Preserve re_def_dynamic_ref so that this symbol will
> >
> > Comment typo.
> >
> >> +++ b/include/bfdlink.h
> >> + /* Symbol is defined in an IR object and referenced in a dynamic
> >> + object. */
> >> + unsigned int ir_def_dynamic_ref : 1;
> >
> > The comment here isn't completely true. The flag will only be set if
> > the dynamic object is linked *after* the IR object, won't it? I think
> > it is worth stating that, or fixing your plugin_notice change to also
> > cover the case where the IR object is linked after a dynamic object.
> >
>
> Here is the updated patch. I updated comments and renamed
> ir_def_dynamic_ref to dynamic_ref_after_ir_def.
OK.
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2017-04-19 23:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 15:44 H.J. Lu
2017-04-19 0:49 ` Alan Modra
2017-04-19 18:04 ` H.J. Lu
2017-04-19 23:25 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419232518.GB24006@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).