From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35899 invoked by alias); 19 Apr 2017 23:25:27 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 35890 invoked by uid 89); 19 Apr 2017 23:25:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=lab X-HELO: mail-io0-f182.google.com Received: from mail-io0-f182.google.com (HELO mail-io0-f182.google.com) (209.85.223.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Apr 2017 23:25:25 +0000 Received: by mail-io0-f182.google.com with SMTP id a103so43104460ioj.1 for ; Wed, 19 Apr 2017 16:25:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=O8UWARkpMxjS9Noq+2/IY2FTV9k/I0Bc5iP/Dw7kwL0=; b=rp+aZt52qEW6i/z5T+EslsO7sIvmQnHpmyY6iS5pxSWL77l+8Vt9Nus3mA3z8OI/bv CFzxDwxWy0SCvhiq+b7kLol97mKDRB2P+PgzlFOGRiOaaQi5xcSsEnv2C8zX4nVOMYhu A9NGqGypw4t5rx/3LFTXOLTD0g0u08nP3ty2tptZZKPNz4V0LKji6FGosxts/EO3GOfm zCZOuSAirvtwdC2xbM3Tx7y2SjbLIoYA14cTXVtNzEy6SNqmUDdV1VUUMuAZ7z6lNeUQ UlrVf8wpRLmMIp54b1C9ZuAeSJ6MrnwgjJqQLwbh9oRSB5N4GB3opJmAP0Km2fd7kOoN e84Q== X-Gm-Message-State: AN3rC/4cKwxYYwZRxN6HD38bAKzEV7Zj7rqbeP99H8ZSPaViKsqiKkPs LgyMtvFfjBTaBg== X-Received: by 10.98.92.1 with SMTP id q1mr5361749pfb.209.1492644323810; Wed, 19 Apr 2017 16:25:23 -0700 (PDT) Received: from bubble.grove.modra.org (CPE-58-160-71-80.tyqh2.lon.bigpond.net.au. [58.160.71.80]) by smtp.gmail.com with ESMTPSA id g71sm5339880pfc.41.2017.04.19.16.25.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Apr 2017 16:25:22 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 53259C766F; Thu, 20 Apr 2017 08:55:18 +0930 (ACST) Date: Wed, 19 Apr 2017 23:25:00 -0000 From: Alan Modra To: "H.J. Lu" Cc: Binutils Subject: Re: [PATCH] PR ld/21382: Handle symbol defined in IR and referenced in DSO Message-ID: <20170419232518.GB24006@bubble.grove.modra.org> References: <20170414154456.GA22259@intel.com> <20170419004855.GY24006@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00166.txt.bz2 On Wed, Apr 19, 2017 at 11:04:48AM -0700, H.J. Lu wrote: > On Tue, Apr 18, 2017 at 5:48 PM, Alan Modra wrote: > > On Fri, Apr 14, 2017 at 08:44:56AM -0700, H.J. Lu wrote: > > > >> +++ b/bfd/elflink.c > >> + /* Preserve re_def_dynamic_ref so that this symbol will > > > > Comment typo. > > > >> +++ b/include/bfdlink.h > >> + /* Symbol is defined in an IR object and referenced in a dynamic > >> + object. */ > >> + unsigned int ir_def_dynamic_ref : 1; > > > > The comment here isn't completely true. The flag will only be set if > > the dynamic object is linked *after* the IR object, won't it? I think > > it is worth stating that, or fixing your plugin_notice change to also > > cover the case where the IR object is linked after a dynamic object. > > > > Here is the updated patch. I updated comments and renamed > ir_def_dynamic_ref to dynamic_ref_after_ir_def. OK. -- Alan Modra Australia Development Lab, IBM