From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104127 invoked by alias); 28 Apr 2017 16:13:11 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 104065 invoked by uid 89); 28 Apr 2017 16:13:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:501 X-HELO: mail-wr0-f171.google.com Received: from mail-wr0-f171.google.com (HELO mail-wr0-f171.google.com) (209.85.128.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Apr 2017 16:13:07 +0000 Received: by mail-wr0-f171.google.com with SMTP id l9so36391019wre.1 for ; Fri, 28 Apr 2017 09:13:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+Ef5kkJBoo7eTOwHDhkL5w4CFzhvb6bQJC1d3bQyhPw=; b=FXmIaFb9mi3WcIq0WRFhNsjon5TSaTD1+Kk31NRit0AW2plp+xb1Ika+jpGWfNDXNu TrszuS6LHcN/o26I1Zzc+X2qPro6C+KeUQplQ1CACXRenf8NRmFrDkV6xVmM3tUHVzFb cccqsTS7iERQzRZcE410CID38xwUscuG5iGfqYSuSyccHsei5QUxAFCFtWPxOBSmJwsz mZEC9HnexRbn/A7Xabaxi9s1o0UdPKPCeGxyA6M+vvAuJefHMi/LvwdxGAkoO2axJq7x X1ah0rTyrbvgcF2/vj9uUsO/We6JdyychXs9KqT3sZlfyuL30xpMQP7AYf/xS0ITtJYZ vIFQ== X-Gm-Message-State: AN3rC/41R3Fv0dL3tCxUzfBSbXai+6UAHXySmx6qya7npMvHDiBRkYVC dBS+LP6c/lN1DV59 X-Received: by 10.223.175.17 with SMTP id z17mr7938672wrc.11.1493395987463; Fri, 28 Apr 2017 09:13:07 -0700 (PDT) Received: from Jamess-MacBook.local (global-184-8.nat-1.net.cam.ac.uk. [131.111.184.8]) by smtp.gmail.com with ESMTPSA id h65sm4893155wrh.32.2017.04.28.09.13.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Apr 2017 09:13:06 -0700 (PDT) Received: by Jamess-MacBook.local (Postfix, from userid 501) id 9CE3D18952FC; Fri, 28 Apr 2017 17:13:05 +0100 (BST) From: James Clarke To: binutils@sourceware.org Cc: James Clarke , John Paul Adrian Glaubitz , Cary Coutant , "Jose E. Marchesi" Subject: [PATCH] gold: Fix assertion failure relaxing TLS for position-independent executables Date: Fri, 28 Apr 2017 16:13:00 -0000 Message-Id: <20170428161214.83513-1-jrtc27@jrtc27.com> X-SW-Source: 2017-04/txt/msg00276.txt.bz2 gold/ PR gold/21444 * gold.cc (Target_sparc::Relocate::relocate_tls): Local variables are final for position-independent executables. This has to be consistent with Target_sparc::Scan::local otherwise they will disagree as to whether local-exec is used. --- gold/sparc.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gold/sparc.cc b/gold/sparc.cc index a9cb93adda..54c7c33498 100644 --- a/gold/sparc.cc +++ b/gold/sparc.cc @@ -3730,7 +3730,7 @@ Target_sparc::Relocate::relocate_tls( const bool is_final = (gsym == NULL - ? !parameters->options().output_is_position_independent() + ? !parameters->options().shared() : gsym->final_value_is_known()); const tls::Tls_optimization optimized_type = optimize_tls_reloc(is_final, r_type); -- 2.12.2