public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* Re: [PATCH] Use the ELF class to determine the word size for FreeBSD core notes.
       [not found] <20170531180757.11380-1-jhb@FreeBSD.org>
@ 2017-06-01  5:57 ` Alan Modra
  2017-06-01 16:55   ` John Baldwin
  0 siblings, 1 reply; 3+ messages in thread
From: Alan Modra @ 2017-06-01  5:57 UTC (permalink / raw)
  To: John Baldwin; +Cc: binutils

On Wed, May 31, 2017 at 11:07:57AM -0700, John Baldwin wrote:
> 	* elf.c (elfcore_grok_freebsd_psinfo): Use ELF header class to
> 	determine structure sizes.
> 	(elfcore_grok_freebsd_prstatus): Likewise.

OK.  I think this is a big improvement over using bits_per_word.

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Use the ELF class to determine the word size for FreeBSD core notes.
  2017-06-01  5:57 ` [PATCH] Use the ELF class to determine the word size for FreeBSD core notes Alan Modra
@ 2017-06-01 16:55   ` John Baldwin
  2017-06-01 23:28     ` Alan Modra
  0 siblings, 1 reply; 3+ messages in thread
From: John Baldwin @ 2017-06-01 16:55 UTC (permalink / raw)
  To: Alan Modra; +Cc: binutils

On Thursday, June 01, 2017 03:27:00 PM Alan Modra wrote:
> On Wed, May 31, 2017 at 11:07:57AM -0700, John Baldwin wrote:
> > 	* elf.c (elfcore_grok_freebsd_psinfo): Use ELF header class to
> > 	determine structure sizes.
> > 	(elfcore_grok_freebsd_prstatus): Likewise.
> 
> OK.  I think this is a big improvement over using bits_per_word.

Thanks, I just pushed this and realized mid-push that I hadn't updated
the date in the ChangeLog entry after rebasing. :(  Is it ok to push
the fixup:

commit 6cf3bf8875d84aff854fe5fe5a04141033d5ee6f
Author: John Baldwin <jhb@FreeBSD.org>
Date:   Thu Jun 1 09:47:31 2017 -0700

    Correct ChangeLog entry date.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 8dfdc23cf3..27a1e8c995 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,4 +1,4 @@
-2017-05-31  John Baldwin  <jhb@FreeBSD.org>
+2017-06-01  John Baldwin  <jhb@FreeBSD.org>
 
        * elf.c (elfcore_grok_freebsd_psinfo): Use ELF header class to
        determine structure sizes.


-- 
John Baldwin

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Use the ELF class to determine the word size for FreeBSD core notes.
  2017-06-01 16:55   ` John Baldwin
@ 2017-06-01 23:28     ` Alan Modra
  0 siblings, 0 replies; 3+ messages in thread
From: Alan Modra @ 2017-06-01 23:28 UTC (permalink / raw)
  To: John Baldwin; +Cc: binutils

On Thu, Jun 01, 2017 at 09:48:25AM -0700, John Baldwin wrote:
> On Thursday, June 01, 2017 03:27:00 PM Alan Modra wrote:
> > On Wed, May 31, 2017 at 11:07:57AM -0700, John Baldwin wrote:
> > > 	* elf.c (elfcore_grok_freebsd_psinfo): Use ELF header class to
> > > 	determine structure sizes.
> > > 	(elfcore_grok_freebsd_prstatus): Likewise.
> > 
> > OK.  I think this is a big improvement over using bits_per_word.
> 
> Thanks, I just pushed this and realized mid-push that I hadn't updated
> the date in the ChangeLog entry after rebasing. :(  Is it ok to push
> the fixup:

We do have an obvious rule, so no need to ask for trivial things like
fixing a changelog entry.

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-01 23:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20170531180757.11380-1-jhb@FreeBSD.org>
2017-06-01  5:57 ` [PATCH] Use the ELF class to determine the word size for FreeBSD core notes Alan Modra
2017-06-01 16:55   ` John Baldwin
2017-06-01 23:28     ` Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).