From: Alan Modra <amodra@gmail.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 3/4] ld: Fix issue where PROVIDE overrides defined symbol
Date: Wed, 10 Jan 2018 06:50:00 -0000 [thread overview]
Message-ID: <20180110065000.GS3071@bubble.grove.modra.org> (raw)
In-Reply-To: <44612a2bda38da51e325b9e8efb4a0550fc1f94c.1515531328.git.andrew.burgess@embecosm.com>
On Tue, Jan 09, 2018 at 09:08:58PM +0000, Andrew Burgess wrote:
> * ldexp.c (exp_fold_tree_1): Rework condition underwhich provide
> nodes are ignored in the tree walk, and move the location at which
> we change provide nodes into provided nodes.
> (exp_init_os): Add etree_provided.
> * testsuite/ld-scripts/provide-6.d: New file.
> * testsuite/ld-scripts/provide-6.t: New file.
> * testsuite/ld-scripts/provide-7.d: New file.
> * testsuite/ld-scripts/provide-7.t: New file.
> * testsuite/ld-scripts/provide-8.d: New file.
> * testsuite/ld-scripts/provide-8.t: New file.
OK, with a few nits fixed.
> + if ((expld.phase == lang_final_phase_enum
> + || expld.assign_name != NULL))
Excess parens here.
> + /* Copy the symbol type if this is an expression only
> + referencing a single symbol. (If the expression
> + contains ternary conditions, ignoring symbols on
> + false branches.) */
> + if (expld.result.valid_p
Testing valid_p here is redundant.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2018-01-10 6:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 21:09 [PATCH 0/4] Fix issue with PROVIDE in linker scripts Andrew Burgess
2018-01-09 21:09 ` [PATCH 3/4] ld: Fix issue where PROVIDE overrides defined symbol Andrew Burgess
2018-01-10 6:50 ` Alan Modra [this message]
2018-01-09 21:09 ` [PATCH 1/4] ld: In map file use '=' in PROVIDE statements Andrew Burgess
2018-01-10 6:45 ` Alan Modra
2018-01-09 21:09 ` [PATCH 4/4] ld: Remove unused expression state Andrew Burgess
2018-01-10 6:50 ` Alan Modra
2018-01-09 21:09 ` [PATCH 2/4] ld: Find and run some tests using a wildcard pattern Andrew Burgess
2018-01-10 6:47 ` Alan Modra
2018-01-11 17:42 ` [PATCH 0/4] Fix issue with PROVIDE in linker scripts Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110065000.GS3071@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=andrew.burgess@embecosm.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).