From: "H.J. Lu" <hjl.tools@gmail.com>
To: binutils@sourceware.org
Subject: [PATCH] x86: Replace evex-no-scale.s with evex-no-scale-[32|64].s
Date: Fri, 10 Aug 2018 17:28:00 -0000 [thread overview]
Message-ID: <20180810172814.7966-1-hjl.tools@gmail.com> (raw)
.if is_64bit
vmovaps -1024(%rip), %zmm0
vmovaps 64(,%rax), %zmm0
vmovaps 64(,%riz), %zmm0
.endif
doesn't with i686-elf cross binutils on 64-bit hosts:
evex-no-scale.s: Assembler messages:
evex-no-scale.s:10: Error: bad register name `%rip)'
evex-no-scale.s:11: Error: bad register name `%rax)'
evex-no-scale.s:12: Error: bad register name `%riz)'
This patch replaces evex-no-scale.s with evex-no-scale-32.s and
evex-no-scale-64.s.
* testsuite/gas/i386/evex-no-scale-32.d: Don't use
evex-no-scale.s.
* testsuite/gas/i386/evex-no-scale-64.d: Likewise.
* testsuite/gas/i386/evex-no-scale-32.s: New file.
* testsuite/gas/i386/evex-no-scale-64.s: Likewise.
* testsuite/gas/i386/evex-no-scale.s: Removed.
---
gas/ChangeLog | 9 +++++++++
gas/testsuite/gas/i386/evex-no-scale-32.d | 1 -
gas/testsuite/gas/i386/evex-no-scale-32.s | 7 +++++++
gas/testsuite/gas/i386/evex-no-scale-64.d | 1 -
.../gas/i386/{evex-no-scale.s => evex-no-scale-64.s} | 10 ----------
5 files changed, 16 insertions(+), 12 deletions(-)
create mode 100644 gas/testsuite/gas/i386/evex-no-scale-32.s
rename gas/testsuite/gas/i386/{evex-no-scale.s => evex-no-scale-64.s} (52%)
diff --git a/gas/ChangeLog b/gas/ChangeLog
index ba6d9ca789..2df3fdb4e7 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,12 @@
+2018-08-10 H.J. Lu <hongjiu.lu@intel.com>
+
+ * testsuite/gas/i386/evex-no-scale.s: Removed.
+ * testsuite/gas/i386/evex-no-scale-32.d: Don't use
+ evex-no-scale.s.
+ * testsuite/gas/i386/evex-no-scale-64.d: Likewise.
+ * testsuite/gas/i386/evex-no-scale-32.s: New file.
+ * testsuite/gas/i386/evex-no-scale-64.s: Likewise.
+
2018-08-09 H.J. Lu <hongjiu.lu@intel.com>
* as.c (show_usage): Display default option for --elf-stt-common=.
diff --git a/gas/testsuite/gas/i386/evex-no-scale-32.d b/gas/testsuite/gas/i386/evex-no-scale-32.d
index e6116bc592..0a2860d32e 100644
--- a/gas/testsuite/gas/i386/evex-no-scale-32.d
+++ b/gas/testsuite/gas/i386/evex-no-scale-32.d
@@ -1,4 +1,3 @@
-#source: evex-no-scale.s
#objdump: -dw
#name: ix86 EVEX no disp scaling
diff --git a/gas/testsuite/gas/i386/evex-no-scale-32.s b/gas/testsuite/gas/i386/evex-no-scale-32.s
new file mode 100644
index 0000000000..e28c73f2a3
--- /dev/null
+++ b/gas/testsuite/gas/i386/evex-no-scale-32.s
@@ -0,0 +1,7 @@
+ .allow_index_reg
+ .text
+disp:
+ vmovaps 64(,%eax), %zmm0
+ vmovaps 64(,%eiz), %zmm0
+ vmovaps 64, %zmm0
+ addr16 vmovaps 64, %zmm0
diff --git a/gas/testsuite/gas/i386/evex-no-scale-64.d b/gas/testsuite/gas/i386/evex-no-scale-64.d
index b66f15bf8b..d52d947ab3 100644
--- a/gas/testsuite/gas/i386/evex-no-scale-64.d
+++ b/gas/testsuite/gas/i386/evex-no-scale-64.d
@@ -1,4 +1,3 @@
-#source: evex-no-scale.s
#objdump: -dw
#name: x86-64 EVEX no disp scaling
diff --git a/gas/testsuite/gas/i386/evex-no-scale.s b/gas/testsuite/gas/i386/evex-no-scale-64.s
similarity index 52%
rename from gas/testsuite/gas/i386/evex-no-scale.s
rename to gas/testsuite/gas/i386/evex-no-scale-64.s
index ed0f2312af..bc3749cc0c 100644
--- a/gas/testsuite/gas/i386/evex-no-scale.s
+++ b/gas/testsuite/gas/i386/evex-no-scale-64.s
@@ -1,19 +1,9 @@
.allow_index_reg
- .section .probe, "", @progbits
-.Lprobe_64bit:
- inc %eax
-.equiv is_64bit, (. - .Lprobe_64bit) / 2
-
.text
disp:
-.if is_64bit
vmovaps -1024(%rip), %zmm0
vmovaps 64(,%rax), %zmm0
vmovaps 64(,%riz), %zmm0
-.endif
vmovaps 64(,%eax), %zmm0
vmovaps 64(,%eiz), %zmm0
vmovaps 64, %zmm0
-.if !is_64bit
- addr16 vmovaps 64, %zmm0
-.endif
--
2.17.1
next reply other threads:[~2018-08-10 17:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 17:28 H.J. Lu [this message]
2018-08-10 19:58 ` H.J. Lu
2018-08-13 6:20 ` Jan Beulich
2018-08-13 11:30 ` H.J. Lu
2018-08-13 12:01 ` Jan Beulich
2018-08-13 12:37 ` H.J. Lu
2018-08-13 12:52 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180810172814.7966-1-hjl.tools@gmail.com \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).