From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62420 invoked by alias); 25 Apr 2019 23:38:44 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 62411 invoked by uid 89); 25 Apr 2019 23:38:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Received:6116, HX-Spam-Relays-External:sk:mail-pf, HX-HELO:sk:mail-pf, H*RU:sk:mail-pf X-HELO: mail-pf1-f180.google.com Received: from mail-pf1-f180.google.com (HELO mail-pf1-f180.google.com) (209.85.210.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Apr 2019 23:38:43 +0000 Received: by mail-pf1-f180.google.com with SMTP id j11so684750pff.13 for ; Thu, 25 Apr 2019 16:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PsogDM/PWZBegobJdzSMzYx4vzTPsnyFfwf7RdhWnMU=; b=uXwQGaQUGCKK6+0M2bNRJws/KxSw9Fomr5w37UQ0j0vHmNF7IUK4/rpttJrMXPfm6u C5O0WP57qu/cvHVBSoHNa90klLbCleAOSELJXnl5zOQT7QSGJSk42akg9bD4LPeul1FW +Igt5OSNp1o+76dANQ2LRhsvAhC1w2Eg7/Nd6x/QIbLEdO9ybUy+qj+cnSjwmkWsM+JB e6jTI6xRorX1cMCEMn6yVQdpBaUgCEPFK9iRBtz9FXlZORlqEZwCiSWdLITEqehyxeJV NRgXfAAqCgWJEThL7u8QFyHlhpwG+IZ7jmuJ3BH4uPcmkmioNaANW+XPa2JmKeeCnsqM RnMg== Return-Path: Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:908e:4809:8d0b:2f86]) by smtp.gmail.com with ESMTPSA id s79sm46662046pfa.31.2019.04.25.16.38.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 16:38:40 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id F3095805D2; Fri, 26 Apr 2019 09:08:36 +0930 (ACST) Date: Thu, 25 Apr 2019 23:38:00 -0000 From: Alan Modra To: "H.J. Lu" Cc: binutils@sourceware.org Subject: Re: [PATCH] Don't complain undefined weak dynamic reference Message-ID: <20190425233836.GF9648@bubble.grove.modra.org> References: <20190425212000.4919-1-hjl.tools@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190425212000.4919-1-hjl.tools@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00241.txt.bz2 On Thu, Apr 25, 2019 at 02:20:00PM -0700, H.J. Lu wrote: > When undefined non-weak references in IR objects are optimized out > by LTO, we can have weak dynamic referencs to symbols marked with > bfd_link_hash_undefined. We shouldn't complain such undefined weak > dynamic references. Looks good to me. > bfd/ > > PR ld/24486 > * elflink.c (elf_link_output_extsym): Don't complain undefined > weak dynamic reference. > > ld/ > > PR ld/24486 > * testsuite/ld-plugin/lto.exp: Run PR ld/24486 tests. > * testsuite/ld-plugin/pr24486a.c: New file. > * testsuite/ld-plugin/pr24486b.c: Likewise. > * testsuite/ld-plugin/pr24486c.c: Likewise. -- Alan Modra Australia Development Lab, IBM