From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88231 invoked by alias); 6 May 2019 06:52:41 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 88217 invoked by uid 89); 6 May 2019 06:52:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=alex, Alex, H*r:sk:static., HX-Spam-Relays-External:sk:mail-pg X-HELO: mail-pg1-f179.google.com Received: from mail-pg1-f179.google.com (HELO mail-pg1-f179.google.com) (209.85.215.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 May 2019 06:52:40 +0000 Received: by mail-pg1-f179.google.com with SMTP id t187so1861703pgb.13 for ; Sun, 05 May 2019 23:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=NNbZfjx5+i9gh4HWEGEhkhqM7RUqbg1DizOMYxfk1Q8=; b=BwG2QrLhtQGuTjuStOlR8ctKWuTOkBtfTP4+DpP5mU5P8ArOnFJ75Bq/wmk15Yg2NO ke72ruyqt+xG0QCmdx0XwtanT6O1PxUtokHJ5sFvvc9CBv/geEPooOup2YsyJgtN+OqD Gtmci6YQb371K1nx63qea/qseLYv5IPGm35xc7TGwbG5LJxRGRLcO0ko+4X9jSHCXEcQ DIsvS4Gk+vLhRzBMcBXQIPDjT7BavVjM+roXG4S/aIbmWjlpout443g4QBdjv1ZSWVUS ZVXeY+6eJlVdcbrLYgIS9o7sPh6H9+qpCPxJwH35ELdi7UAzCBatrpUq9z8w8iWUp64i b8pQ== Return-Path: Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id n18sm19842320pfi.48.2019.05.05.23.52.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 May 2019 23:52:37 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id E498189FFF; Mon, 6 May 2019 16:22:33 +0930 (ACST) Date: Mon, 06 May 2019 06:52:00 -0000 From: Alan Modra To: binutils@sourceware.org Cc: Alexandre Oliva Subject: sym->sy_value is not valid for struct local_symbol Message-ID: <20190506065233.GN3195@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00131.txt.bz2 Fixes this mep-elf error: gas/elf/dwarf2-19.s: Error: Unknown expression operator (enum 0) gas/elf/dwarf2-19.s: Error: cannot convert expression symbol .L2 to complex relocation Doesn't fix the test itself from failing though. Alex, your latest patch resulted in: mep-elf +FAIL: DWARF2 18 mep-elf +FAIL: DWARF2 19 * symbols.c (symbol_relc_make_sym): Do not access sym->sy_value directly. diff --git a/gas/symbols.c b/gas/symbols.c index 97867954fd..10d7b1c273 100644 --- a/gas/symbols.c +++ b/gas/symbols.c @@ -3288,7 +3288,7 @@ symbol_relc_make_sym (symbolS * sym) is defined as an expression or a plain value. */ if ( S_GET_SEGMENT (sym) == expr_section || S_GET_SEGMENT (sym) == absolute_section) - return symbol_relc_make_expr (& sym->sy_value); + return symbol_relc_make_expr (symbol_get_value_expression (sym)); /* This may be a "fake symbol", referring to ".". Write out a special null symbol to refer to this position. */ -- Alan Modra Australia Development Lab, IBM