public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* tic54x_start_line_hook
@ 2019-05-15  4:14 Alan Modra
  0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2019-05-15  4:14 UTC (permalink / raw)
  To: binutils

git commit 3076e59490 caused
tic54x-coff  +FAIL: c54x subsym assignment/use

We want to skip over \n but not 0.

	PR 24538
	* config/tc-tic54x.c (tic54x_start_line_hook): Do skip end of line
	chars in setting endp.

diff --git a/gas/config/tc-tic54x.c b/gas/config/tc-tic54x.c
index 6e2b05d39b..3e1d32a02e 100644
--- a/gas/config/tc-tic54x.c
+++ b/gas/config/tc-tic54x.c
@@ -4738,12 +4738,9 @@ tic54x_start_line_hook (void)
   char *replacement = NULL;
 
   /* Work with a copy of the input line, including EOL char.  */
-  for (endp = input_line_pointer; ; endp ++)
-    {
-      unsigned char c = * (unsigned char *) endp;
-      if (c == 0 || is_end_of_line [c])
-	break;
-    }
+  for (endp = input_line_pointer; *endp != 0; )
+    if (is_end_of_line[(unsigned char) *endp++])
+      break;
 
   line = xmemdup0 (input_line_pointer, endp - input_line_pointer);
 

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-05-15  4:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-15  4:14 tic54x_start_line_hook Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).