public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Alcock <nick.alcock@oracle.com>
To: binutils@sourceware.org
Subject: [PATCH v2 16/19] libctf: labels
Date: Fri, 17 May 2019 22:12:00 -0000	[thread overview]
Message-ID: <20190517221002.408822-17-nick.alcock@oracle.com> (raw)
In-Reply-To: <20190517221002.408822-1-nick.alcock@oracle.com>

This facility allows you to associate regions of type IDs with *labels*,
a labelled tiling of the type ID space. You can use these to define
CTF containers with distinct parents for distinct ranges of the ID
space, or to assist with parallelization of CTF processing, or for any
other purpose you can think of.

Notably absent from here (though declared in the API header) is any way
to define new labels: this will probably be introduced soon, as part of
the linker deduplication work.  (One existed in the past, but was deeply
tied to the Solaris CTF file generator and had to be torn out.)

I would be happy to drop this entire commit for now as half-baked, but
it's an ancient interface and so to some degree shows what the original
designers of CTF thought you could do with it.

Changes from v1:
 - Correct erroneous license (GPLv2+ -> v3+) and reset copyright years.

libctf/
	* ctf-labels.c: New.
include/
	* ctf-api.h (ctf_label_f): New.
	(ctf_label_set): New.
	(ctf_label_get): New.
	(ctf_label_topmost): New.
	(ctf_label_info): New.
	(ctf_label_iter): New.
---
 include/ctf-api.h   |   9 +++
 libctf/ctf-labels.c | 138 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 147 insertions(+)
 create mode 100644 libctf/ctf-labels.c

diff --git a/include/ctf-api.h b/include/ctf-api.h
index 6d6efdd513..14a61520bb 100644
--- a/include/ctf-api.h
+++ b/include/ctf-api.h
@@ -213,6 +213,8 @@ typedef int ctf_member_f (const char *name, ctf_id_t membtype,
 typedef int ctf_enum_f (const char *name, int val, void *arg);
 typedef int ctf_variable_f (const char *name, ctf_id_t type, void *arg);
 typedef int ctf_type_f (ctf_id_t type, void *arg);
+typedef int ctf_label_f (const char *name, const ctf_lblinfo_t *info,
+			 void *arg);
 typedef int ctf_archive_member_f (ctf_file_t *fp, const char *name, void *arg);
 typedef int ctf_archive_raw_member_f (const char *name, const void *content,
 				      size_t len, void *arg);
@@ -279,9 +281,16 @@ extern int ctf_array_info (ctf_file_t *, ctf_id_t, ctf_arinfo_t *);
 extern const char *ctf_enum_name (ctf_file_t *, ctf_id_t, int);
 extern int ctf_enum_value (ctf_file_t *, ctf_id_t, const char *, int *);
 
+extern void ctf_label_set (ctf_file_t *, const char *);
+extern const char *ctf_label_get (ctf_file_t *);
+
+extern const char *ctf_label_topmost (ctf_file_t *);
+extern int ctf_label_info (ctf_file_t *, const char *, ctf_lblinfo_t *);
+
 extern int ctf_member_iter (ctf_file_t *, ctf_id_t, ctf_member_f *, void *);
 extern int ctf_enum_iter (ctf_file_t *, ctf_id_t, ctf_enum_f *, void *);
 extern int ctf_type_iter (ctf_file_t *, ctf_type_f *, void *);
+extern int ctf_label_iter (ctf_file_t *, ctf_label_f *, void *);
 extern int ctf_variable_iter (ctf_file_t *, ctf_variable_f *, void *);
 extern int ctf_archive_iter (const ctf_archive_t *, ctf_archive_member_f *,
 			     void *);
diff --git a/libctf/ctf-labels.c b/libctf/ctf-labels.c
new file mode 100644
index 0000000000..9b9fffea4e
--- /dev/null
+++ b/libctf/ctf-labels.c
@@ -0,0 +1,138 @@
+/* Labelled ranges of type IDs.
+   Copyright (C) 2019 Free Software Foundation, Inc.
+
+   This file is part of libctf.
+
+   libctf is free software; you can redistribute it and/or modify it under
+   the terms of the GNU General Public License as published by the Free
+   Software Foundation; either version 3, or (at your option) any later
+   version.
+
+   This program is distributed in the hope that it will be useful, but
+   WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+   See the GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program; see the file COPYING.  If not see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <ctf-impl.h>
+#include <string.h>
+
+static int
+extract_label_info (ctf_file_t *fp, const ctf_lblent_t **ctl,
+		    uint32_t *num_labels)
+{
+  const ctf_header_t *h;
+
+  h = (const ctf_header_t *) fp->ctf_data.cts_data;
+
+  *ctl = (const ctf_lblent_t *) (fp->ctf_buf + h->cth_lbloff);
+  *num_labels = (h->cth_objtoff - h->cth_lbloff) / sizeof (ctf_lblent_t);
+
+  return 0;
+}
+
+/* Returns the topmost label, or NULL if any errors are encountered.  */
+
+const char *
+ctf_label_topmost (ctf_file_t *fp)
+{
+  const ctf_lblent_t *ctlp = NULL;
+  const char *s;
+  uint32_t num_labels = 0;
+
+  if (extract_label_info (fp, &ctlp, &num_labels) == CTF_ERR)
+    return NULL;				/* errno is set for us.  */
+
+  if (num_labels == 0)
+    {
+      (void) ctf_set_errno (fp, ECTF_NOLABELDATA);
+      return NULL;
+    }
+
+  if ((s = ctf_strraw (fp, (ctlp + num_labels - 1)->ctl_label)) == NULL)
+    (void) ctf_set_errno (fp, ECTF_CORRUPT);
+
+  return s;
+}
+
+/* Iterate over all labels.  We pass the label string and the lblinfo_t struct
+   to the specified callback function.  */
+int
+ctf_label_iter (ctf_file_t *fp, ctf_label_f *func, void *arg)
+{
+  const ctf_lblent_t *ctlp = NULL;
+  uint32_t i;
+  uint32_t num_labels = 0;
+  ctf_lblinfo_t linfo;
+  const char *lname;
+  int rc;
+
+  if (extract_label_info (fp, &ctlp, &num_labels) == CTF_ERR)
+    return CTF_ERR;		/* errno is set for us.  */
+
+  if (num_labels == 0)
+    return (ctf_set_errno (fp, ECTF_NOLABELDATA));
+
+  for (i = 0; i < num_labels; i++, ctlp++)
+    {
+      if ((lname = ctf_strraw (fp, ctlp->ctl_label)) == NULL)
+	{
+	  ctf_dprintf ("failed to decode label %u with "
+		       "type %u\n", ctlp->ctl_label, ctlp->ctl_type);
+	  return (ctf_set_errno (fp, ECTF_CORRUPT));
+	}
+
+      linfo.ctb_type = ctlp->ctl_type;
+      if ((rc = func (lname, &linfo, arg)) != 0)
+	return rc;
+    }
+
+  return 0;
+}
+
+typedef struct linfo_cb_arg
+{
+  const char *lca_name;		/* Label we want to retrieve info for.  */
+  ctf_lblinfo_t *lca_info;	/* Where to store the info about the label.  */
+} linfo_cb_arg_t;
+
+static int
+label_info_cb (const char *lname, const ctf_lblinfo_t *linfo, void *arg)
+{
+  /* If lname matches the label we are looking for, copy the
+    lblinfo_t struct for the caller.  */
+
+  if (strcmp (lname, ((linfo_cb_arg_t *) arg)->lca_name) == 0)
+    {
+      /* * Allow caller not to allocate storage to test if label exists.  */
+
+      if (((linfo_cb_arg_t *) arg)->lca_info != NULL)
+	memcpy (((linfo_cb_arg_t *) arg)->lca_info, linfo,
+	       sizeof (ctf_lblinfo_t));
+      return 1;		/* Indicate we found a match.  */
+    }
+
+  return 0;
+}
+
+/* Retrieve information about the label with name "lname". */
+int
+ctf_label_info (ctf_file_t *fp, const char *lname, ctf_lblinfo_t *linfo)
+{
+  linfo_cb_arg_t cb_arg;
+  int rc;
+
+  cb_arg.lca_name = lname;
+  cb_arg.lca_info = linfo;
+
+  if ((rc = ctf_label_iter (fp, label_info_cb, &cb_arg)) == CTF_ERR)
+    return rc;
+
+  if (rc != 1)
+    return (ctf_set_errno (fp, ECTF_NOLABEL));
+
+  return 0;
+}
-- 
2.21.0.237.gd0cfaa883d

  parent reply	other threads:[~2019-05-17 22:12 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 22:10 [PATCH v2 00/19] libctf, and CTF support for objdump and readelf Nick Alcock
2019-05-17 22:10 ` [PATCH v2 12/19] libctf: lookups by name and symbol Nick Alcock
2019-05-17 22:10 ` [PATCH v2 05/19] libctf: error handling Nick Alcock
2019-05-17 22:10 ` [PATCH v2 17/19] libctf: debug dumping Nick Alcock
2019-05-17 22:10 ` [PATCH v2 01/19] include: new header ctf.h: file format description Nick Alcock
2019-05-17 22:10 ` [PATCH v2 07/19] libctf: implementation definitions related to file creation Nick Alcock
2019-05-17 22:10 ` [PATCH v2 03/19] libctf: lowest-level memory allocation and debug-dumping wrappers Nick Alcock
2019-05-17 22:10 ` [PATCH v2 06/19] libctf: hashing Nick Alcock
2019-05-17 22:10 ` [PATCH v2 19/19] binutils: CTF support for objdump and readelf Nick Alcock
2019-05-17 22:10 ` [PATCH v2 15/19] libctf: mmappable archives Nick Alcock
2019-05-17 22:10 ` [PATCH v2 14/19] libctf: library version enforcement Nick Alcock
2019-05-17 22:10 ` [PATCH v2 08/19] libctf: creation functions Nick Alcock
2019-05-29 14:09   ` Szabolcs Nagy
2019-05-29 14:19     ` Nick Alcock
2019-05-17 22:10 ` [PATCH v2 04/19] libctf: low-level list manipulation and helper utilities Nick Alcock
2019-05-17 22:10 ` [PATCH v2 13/19] libctf: type copying Nick Alcock
2019-05-17 22:10 ` [PATCH v2 09/19] libctf: opening Nick Alcock
2019-05-17 22:10 ` [PATCH v2 10/19] libctf: ELF file opening via BFD Nick Alcock
2019-05-17 22:10 ` [PATCH v2 02/19] include: new header ctf-api.h Nick Alcock
2019-05-17 22:11 ` [PATCH v2 18/19] libctf: build system Nick Alcock
2019-05-17 22:12 ` Nick Alcock [this message]
2019-05-17 22:12 ` [PATCH v2 11/19] libctf: core type lookup Nick Alcock
2019-05-20 19:27 ` [PATCH v2 00/19] libctf, and CTF support for objdump and readelf Joseph Myers
2019-05-20 20:50   ` Nick Alcock
2019-05-28  8:33 ` Nick Clifton
2019-05-28  9:56   ` Nick Alcock
2019-05-28 16:39   ` Jose E. Marchesi
2019-05-28 19:16     ` Christophe Lyon
2019-05-28 21:36       ` Nix
2019-05-29  3:25         ` Alan Modra
2019-05-29  9:14           ` Jose E. Marchesi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190517221002.408822-17-nick.alcock@oracle.com \
    --to=nick.alcock@oracle.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).