From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85385 invoked by alias); 21 May 2019 01:07:20 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 85376 invoked by uid 89); 21 May 2019 01:07:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.210.196, H*RU:209.85.210.196, HX-Spam-Relays-External:sk:mail-pf, HX-HELO:sk:mail-pf X-HELO: mail-pf1-f196.google.com Received: from mail-pf1-f196.google.com (HELO mail-pf1-f196.google.com) (209.85.210.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 May 2019 01:07:18 +0000 Received: by mail-pf1-f196.google.com with SMTP id 13so8094617pfw.9 for ; Mon, 20 May 2019 18:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=VDlVZAtVfZacLJQx+1lCwAHgupTKAYX6m4H6GIBKXkc=; b=vQzLVH+hUzd7R9MEJvsbbR4g9+LLa85eZA78qG9HdfA2mkGWri9WVnUnKQ7s2bbxi1 wIFuDOx+APjJFUEXb0o7p2fFNJKRVr0atn2BxkVU6xLRc2A34hugtPdsE0AnWr9qhI1o 2YnsWfrosjN2H5zzgFSwD1Y289lP6mhf4kCdrnPEE3SNsyZEzJvESEuSUaLi3GjpPerT zxyloWab9WOYkWzaPPsFbvYczGk/4XBKd2b+c44Nv8n/8agZKDSBGGARSTR7BlVlOs6K GijXzPSGuLOJqQPqapZMy8L/2DYfunbyhsPP7b2IXvkHLy4FfHO7RR5is91Oo89prjwW zdEQ== Return-Path: Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id f29sm47396359pfq.11.2019.05.20.18.07.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 May 2019 18:07:16 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 8680580573; Tue, 21 May 2019 10:37:11 +0930 (ACST) Date: Tue, 21 May 2019 01:07:00 -0000 From: Alan Modra To: John Darrington Cc: binutils@sourceware.org Subject: Re: [PATCH] GAS: Replace macro LITERAL_PREFIXDOLLAR_HEX with a runtime value. Message-ID: <20190521010709.GP6820@bubble.grove.modra.org> References: <20190516101810.26247-1-john@darrington.wattle.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190516101810.26247-1-john@darrington.wattle.id.au> User-Agent: Mutt/1.9.4 (2018-02-28) X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00257.txt.bz2 This patch caused build failures on m68hc11, m68hc12 and m68k. Please fix. You also forgot to commit an entry in gas/ChangeLog. /home/alan/src/binutils-gdb/gas/expr.c: In function ‘operand’: /home/alan/src/binutils-gdb/gas/expr.c:1125:5: error: duplicate case value 1125 | case '$': | ^~~~ /home/alan/src/binutils-gdb/gas/expr.c:783:5: note: previously used here 783 | case '$': | ^~~~ Makefile:1224: recipe for target 'expr.o' failed -- Alan Modra Australia Development Lab, IBM