From: Alan Modra <amodra@gmail.com>
To: "David Lanzenörfer" <leviathan@libresilicon.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 2/2] z/OS support: Introducing z/OS support
Date: Mon, 27 Jan 2020 08:42:00 -0000 [thread overview]
Message-ID: <20200127084233.GR4433@bubble.grove.modra.org> (raw)
In-Reply-To: <20200126113756.2009-5-leviathan@libresilicon.com>
On Sun, Jan 26, 2020 at 07:37:56PM +0800, David Lanzenörfer wrote:
> create mode 100644 bfd/po-bfd.h
> create mode 100644 bfd/po64-s390.c
> create mode 100644 include/po/common.h
> create mode 100644 include/po/external.h
> create mode 100644 include/po/internal.h
> create mode 100644 ld/emulparams/po64_s390.sh
> create mode 100644 ld/scripttempl/po64_s390.sc
These are really jarring names to anyone who is accustomed to po files
as Gettext Portable Object files. Please change them. zpo maybe.
You also have a lot of identifiers starting with po, those also would
be better as zpo or something else.
> + _bfd_dummy_target,
> + _bfd_dummy_target, /* TODO: bfd_po_object_p */
> + _bfd_dummy_target,
> + _bfd_dummy_target
Without an object_p function BFD can't read your object files! So
this is a write-only format. You can't inspect symbols, you can't
objcopy or objdump the files. How do you test anything?
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2020-01-27 8:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 11:38 [PATCH 0/2] Introducing support for cross compiling/linking for the z/OS platform David Lanzenörfer
2020-01-26 11:38 ` [PATCH 1/2] z/OS Support: Catching segfaults David Lanzenörfer
2020-01-27 7:18 ` Alan Modra
2020-01-28 7:39 ` David Lanzendörfer
2020-01-26 11:38 ` [PATCH 2/2] " David Lanzenörfer
2020-01-26 11:38 ` [PATCH 1/2] z/OS support: Introducing z/OS support David Lanzenörfer
2020-01-26 11:38 ` [PATCH 2/2] " David Lanzenörfer
2020-01-27 8:42 ` Alan Modra [this message]
2020-01-28 7:37 ` David Lanzendörfer
2020-01-26 15:50 ` [PATCH 0/2] Introducing support for cross compiling/linking for the z/OS platform David Lanzendörfer
2020-01-26 11:43 David Lanzenörfer
2020-01-26 11:43 ` [PATCH 2/2] z/OS support: Introducing z/OS support David Lanzenörfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127084233.GR4433@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=leviathan@libresilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).