From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117261 invoked by alias); 27 Jan 2020 08:42:41 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 117200 invoked by uid 89); 27 Jan 2020 08:42:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mail-pl1-f196.google.com Received: from mail-pl1-f196.google.com (HELO mail-pl1-f196.google.com) (209.85.214.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Jan 2020 08:42:39 +0000 Received: by mail-pl1-f196.google.com with SMTP id g6so3506974plt.2 for ; Mon, 27 Jan 2020 00:42:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=LQfOJGdsJWAHB3DUO2ptXZNlKBmOVHTXqIPDG7FwNEs=; b=N6ssWcpAnXetkhd0qsT8Pckh14mQA6OK5SgxqZgVUsEUqFdCKBK/c1GyvBvmji4N5a PwgJVvgB5SmEmiqoY0lfh6ldFDIB4YKdla20wASindmLu6lNqhcqG9ezdPWS0OvTQot5 +LkbHf4VaWx51brDdyiJkAlSSeADW9I+kQpkRol0QFkOUii6TW2G6kVuhI1qmeH1Dyac +RcCtQ2T+S0y9UTt0ut42tv3K/e4pKALGKYSLBPXXVV12xzu8187ZrkqUT+CC5SxYmh4 rG+K2FEriTvLf8IhGvr54GUaAXUWNBUxN4ZHsfIBibx3YzhMihL2l0kbSXqyLvIVgdCa /9uA== Return-Path: Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id a17sm15128264pjv.6.2020.01.27.00.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jan 2020 00:42:37 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 05B6680903; Mon, 27 Jan 2020 19:12:33 +1030 (ACDT) Date: Mon, 27 Jan 2020 08:42:00 -0000 From: Alan Modra To: David =?iso-8859-1?Q?Lanzen=F6rfer?= Cc: binutils@sourceware.org Subject: Re: [PATCH 2/2] z/OS support: Introducing z/OS support Message-ID: <20200127084233.GR4433@bubble.grove.modra.org> References: <20200126113756.2009-1-leviathan@libresilicon.com> <20200126113756.2009-5-leviathan@libresilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200126113756.2009-5-leviathan@libresilicon.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00382.txt.bz2 On Sun, Jan 26, 2020 at 07:37:56PM +0800, David Lanzenörfer wrote: > create mode 100644 bfd/po-bfd.h > create mode 100644 bfd/po64-s390.c > create mode 100644 include/po/common.h > create mode 100644 include/po/external.h > create mode 100644 include/po/internal.h > create mode 100644 ld/emulparams/po64_s390.sh > create mode 100644 ld/scripttempl/po64_s390.sc These are really jarring names to anyone who is accustomed to po files as Gettext Portable Object files. Please change them. zpo maybe. You also have a lot of identifiers starting with po, those also would be better as zpo or something else. > + _bfd_dummy_target, > + _bfd_dummy_target, /* TODO: bfd_po_object_p */ > + _bfd_dummy_target, > + _bfd_dummy_target Without an object_p function BFD can't read your object files! So this is a write-only format. You can't inspect symbols, you can't objcopy or objdump the files. How do you test anything? -- Alan Modra Australia Development Lab, IBM