Re: [PATCH] Use GCC LTO wrapper to get real symbols from LTO IR objects

[Alan Modra <amodra@gmail.com>]

Wow, that's a lot of work to get proper symbol type.  What happens if
you run nm on a system where gcc isn't installed?  Or where the lto
version doesn't match?

On Mon, Feb 10, 2020 at 01:31:16PM -0800, H.J. Lu wrote:
> +  gcc_name = bfd_malloc (length + target_length + sizeof ("gcc"));
> +  memcpy (gcc_name, real_name, length);

No check of bfd_malloc return value before use.

> +  wrapper_name = bfd_malloc (length + sizeof ("lto-wrapper"));
> +  memcpy (wrapper_name, real_name, length);

Again.

> +  real_syms = (asymbol **) xmalloc (real_symsize);

xmalloc shouldn't be used in libbfd.

>    struct plugin_data_struct *plugin_data =
>      bfd_alloc (abfd, sizeof (plugin_data_struct));

This also doesn't check for NULL, preexisting bug.

> +  int i;
> +
> +  /* NB: LTO symbols are owned by LTO plugin.  Create a copy so that we
> +     can use it in bfd_plugin_canonicalize_symtab.  */
> +  copy_of_syms = bfd_alloc (abfd, nsyms * sizeof (*syms));
> +  memcpy (copy_of_syms, syms, nsyms * sizeof (*syms));
> +  for (i = 0; i < nsyms; i++)
> +    copy_of_syms[i].name = xstrdup (syms[i].name);

xstrdup shouldn't be used in libbfd.

-- 
Alan Modra
Australia Development Lab, IBM