From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97024 invoked by alias); 19 Feb 2020 22:55:11 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 97008 invoked by uid 89); 19 Feb 2020 22:55:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=habits, Joe, H*f:sk:eBypKLe, H*i:sk:eBypKLe X-HELO: mail-pl1-f171.google.com Received: from mail-pl1-f171.google.com (HELO mail-pl1-f171.google.com) (209.85.214.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Feb 2020 22:55:09 +0000 Received: by mail-pl1-f171.google.com with SMTP id y1so702337plp.7 for ; Wed, 19 Feb 2020 14:55:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1KpMTnID7fk++X9/JgO4hjbU4fJWk3CP0ekZ73IMvWg=; b=NqBTNoWSaMrIhzaL5VY1cNmHuNmO5rH3HaF5lCrHJxCamE1fYloYD3y6bmkUI7D8C5 uJlZ7CIt5p1aQoeTJaXkJxkoHf/BvIUN1ubzQumiCuQyKCUmpBqWeE8bUsMMeCPEaEa+ OsH+2AtvgKC5+2POvS9B6xQohQySr6JlidsGibRO4TJJeQOaplc0Jvk+gNUD8MHoDPg0 +5G6s09DXtEx5/bdz5wVylOD1sfIs/G5OpkxK4F6E7Rdz45poht6W6209efvZo+XsqRa CUHZ9EjZdyU2quns5y1+smHz+DB0F1otNY+zctkvSV8q54if5OZhoFzH4I7a1A9J5+aK g2Wg== Return-Path: Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id i64sm744257pgc.51.2020.02.19.14.55.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 14:55:07 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 00CC280539; Thu, 20 Feb 2020 09:25:03 +1030 (ACDT) Date: Wed, 19 Feb 2020 22:55:00 -0000 From: Alan Modra To: binutils@sourceware.org Cc: Eric Christopher Subject: Committing patches for other people Message-ID: <20200219225503.GV5570@bubble.grove.modra.org> References: <20200214201441.146590-1-rupprecht@google.com> <20200219090334.GR5570@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00485.txt.bz2 On Wed, Feb 19, 2020 at 01:58:20PM -0800, Eric Christopher wrote: > I've gone ahead and committed this for Jordan. OK, but I'll note that when not using "git am" to commit other people's patches you should take steps to properly attribute authorship. git commit --amend --author="Joe Bloe " As it is, "git blame" shows 741cb83912f (Eric Christopher 2020-02-19 13:55:25 -0800 for objdump.c lines changed by Jordan's patch. None of this matters very much at the moment, but if we are to move away from ChangeLogs then we will need to learn better habits. -- Alan Modra Australia Development Lab, IBM