From: Alan Modra <amodra@gmail.com>
To: Fangrui Song <i@maskray.me>
Cc: binutils <binutils@sourceware.org>
Subject: Re: [ld] section address : ALIGN(align) and the maximum of input section alignments
Date: Wed, 04 Mar 2020 05:56:00 -0000 [thread overview]
Message-ID: <20200304055641.GT5384@bubble.grove.modra.org> (raw)
In-Reply-To: <BY5PR07MB7316674DD98011D2AD812A63CBE40@BY5PR07MB7316.namprd07.prod.outlook.com>
On Tue, Mar 03, 2020 at 03:58:12PM -0800, Fangrui Song wrote:
> Thanks. For the example below, do you agree with the comments in a.x below?
>
> % cat a.s
> .globl _start; _start: ret
> .section .data.rel.ro,"aw"; .balign 8; .byte 0
> .data; .byte 0
> .section .data2,"aw"; .balign 8; .byte 0
> .section .data3,"aw"; .balign 32; .byte 0
> .bss; .balign 32; .byte 0
> % as a.s -o a.o
>
> % cat a.x
> SECTIONS {
> .text 0x10000 : { *(.text) }
> /* sh_addr is 0x10010. Specifying both address and ALIGN should be
> disallowed. */
> .data.rel.ro . : ALIGN(16) { *(.data.rel.ro) }
>
> .data 0x20000 : { *(.data) }
> /* sh_addr is 0x20001. Should there be a warning that sh_addralign
> is 8? Even --warn-section-align does not warn. */
That is a bug.
The ELF gABI says in part of sh_addralign: "The value of sh_addr must
be congruent to 0, modulo the value of sh_addralign."
* elf.c (elf_fake_sections): Ensure sh_addralign is such that
sh_addr mod sh_addalign is zero.
diff --git a/bfd/elf.c b/bfd/elf.c
index fcd84d2d17..c4d6718aaa 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -3192,6 +3192,7 @@ elf_fake_sections (bfd *abfd, asection *asect, void *fsarg)
unsigned int sh_type;
const char *name = asect->name;
bfd_boolean delay_st_name_p = FALSE;
+ bfd_vma mask;
if (arg->failed)
{
@@ -3291,7 +3292,10 @@ elf_fake_sections (bfd *abfd, asection *asect, void *fsarg)
arg->failed = TRUE;
return;
}
- this_hdr->sh_addralign = (bfd_vma) 1 << asect->alignment_power;
+ /* Set sh_addralign to the highest power of two given by alignment
+ consistent with the section VMA. Linker scripts can force VMA. */
+ mask = ((bfd_vma) 1 << asect->alignment_power) | this_hdr->sh_addr;
+ this_hdr->sh_addralign = mask & -mask;
/* The sh_entsize and sh_info fields may have been set already by
copy_private_section_data. */
> .data2 . : { *(.data2) }
> /* sh_addr is 0x20020. The input section alignment wins. */
> .data3 : ALIGN(16) { *(.data3) }
> /* sh_addr is 0x20030. Specifying both address and ALIGN should be
> disallowed. */
> .bss . : ALIGN(16) { *(.bss) }
> }
>
> % ld.bfd -T a.x a.s -o a
>
> If specifying both Output Section Address and ALIGN is disallowed,
> there should be no "changing start of section" warning when
> --warn-section-align is not specified. Is my understanding correct?
>
> BTW, I filed a bug about duplicate "changing start of section"
> warnings https://sourceware.org/bugzilla/show_bug.cgi?id=25570
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2020-03-04 5:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 5:23 Fangrui Song
2020-02-26 6:31 ` Fangrui Song
2020-03-03 5:46 ` Fangrui Song
2020-03-03 22:39 ` Alan Modra
2020-03-04 0:03 ` Fangrui Song
[not found] ` <BY5PR07MB7316674DD98011D2AD812A63CBE40@BY5PR07MB7316.namprd07.prod.outlook.com>
2020-03-04 5:56 ` Alan Modra [this message]
2020-03-04 6:40 ` Fangrui Song
2020-03-04 8:04 ` Alan Modra
2020-03-05 6:41 ` Fangrui Song
2020-03-05 11:21 ` Alan Modra
2020-03-10 19:00 ` Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304055641.GT5384@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=i@maskray.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).